Bug 110057 - [GTK][AC] Implement keyframe animations with clutter ac backend
Summary: [GTK][AC] Implement keyframe animations with clutter ac backend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 105699
  Show dependency tree / graph
 
Reported: 2013-02-17 10:58 PST by ChangSeok Oh
Modified: 2013-02-19 09:03 PST (History)
3 users (show)

See Also:

Attachments
Patch (21.80 KB, patch)
2013-02-17 11:19 PST, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Patch (21.98 KB, patch)
2013-02-19 07:42 PST, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2013-02-17 10:58:30 PST 
This bug is for bringing accelearted animation with clutter to webkitgtk port.
Comment 1 ChangSeok Oh 2013-02-17 11:19:08 PST 
Created attachment 188770 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-02-19 06:37:18 PST 
Comment on attachment 188770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188770&action=review

> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:775
> +            // If any matrix is singular, CA won't animate it correctly. So fall back to software animation

CA reference.
Comment 3 Gustavo Noronha (kov) 2013-02-19 06:37:37 PST 
Comment on attachment 188770 [details]
Patch

Err, actually, there was a nit, so cq-
Comment 4 ChangSeok Oh 2013-02-19 07:42:52 PST 
Created attachment 189089 [details]
Patch
Comment 5 ChangSeok Oh 2013-02-19 07:45:33 PST 
Comment on attachment 188770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188770&action=review

Thank you for the review :)

>> Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:775
>> +            // If any matrix is singular, CA won't animate it correctly. So fall back to software animation
> 
> CA reference.

Updated this comment.
Comment 6 WebKit Review Bot 2013-02-19 09:03:14 PST 
Comment on attachment 189089 [details]
Patch

Clearing flags on attachment: 189089

Committed r143343: <http://trac.webkit.org/changeset/143343>
Comment 7 WebKit Review Bot 2013-02-19 09:03:18 PST 
All reviewed patches have been landed.  Closing bug.