Bug 110047 - [Regression] SVG images used as background images are incorrectly scaled.
Summary: [Regression] SVG images used as background images are incorrectly scaled.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philip Rogers
URL:
Keywords:
Depends on:
Blocks: 109609
  Show dependency tree / graph
 
Reported: 2013-02-16 21:54 PST by Philip Rogers
Modified: 2013-02-18 13:27 PST (History)
6 users (show)

See Also:

Attachments
Testcase (1.26 KB, text/html)
2013-02-16 21:54 PST, Philip Rogers 		no flags Details
Fix scaling of tiled SVG backgrounds on high-dpi displays (7.70 KB, patch)
2013-02-17 21:58 PST, Philip Rogers 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Rogers 2013-02-16 21:54:21 PST 
Created attachment 188754 [details]
Testcase

Almost certainly a regression from r142765.

SVG images as backgrounds are rendering with scale applied twice on Skia-backed ports. See the attached testcase for an example.
Comment 1 Philip Rogers 2013-02-17 21:58:17 PST 
Created attachment 188796 [details]
Fix scaling of tiled SVG backgrounds on high-dpi displays

A nasty regression: I can't believe we had no test coverage of this!
Comment 2 Philip Rogers 2013-02-18 10:46:22 PST 
Comment on attachment 188796 [details]
Fix scaling of tiled SVG backgrounds on high-dpi displays

Removing the review flag. After sleeping on this, we really need to split this into two patches.
Comment 3 Philip Rogers 2013-02-18 12:23:32 PST 
Comment on attachment 188796 [details]
Fix scaling of tiled SVG backgrounds on high-dpi displays

Re-adding the review flag.

I investigated separating this patch into two and I think landing these together is better after all.
Comment 4 Dirk Schulze 2013-02-18 12:42:08 PST 
Comment on attachment 188796 [details]
Fix scaling of tiled SVG backgrounds on high-dpi displays

LGTM. r=me
Comment 5 Philip Rogers 2013-02-18 12:45:28 PST 
Comment on attachment 188796 [details]
Fix scaling of tiled SVG backgrounds on high-dpi displays

Thanks for the review!
Comment 6 WebKit Review Bot 2013-02-18 13:27:13 PST 
Comment on attachment 188796 [details]
Fix scaling of tiled SVG backgrounds on high-dpi displays

Clearing flags on attachment: 188796

Committed r143257: <http://trac.webkit.org/changeset/143257>
Comment 7 WebKit Review Bot 2013-02-18 13:27:16 PST 
All reviewed patches have been landed.  Closing bug.