RESOLVED FIXED Bug 110046
Remove multi-threading gunk from WebKit2's PluginInfoStore. 
https://bugs.webkit.org/show_bug.cgi?id=110046
Summary Remove multi-threading gunk from WebKit2's PluginInfoStore.
Andreas Kling
Reported 2013-02-16 21:11:36 PST
There's some cruft left behind after removing the multi-threading code from WK2's PluginInfoStore.
Attachments
Patch (7.41 KB, patch)
2013-02-16 21:21 PST, Andreas Kling 		ap: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-02-16 21:21:22 PST
Created attachment 188753 [details] Patch
Build Bot
Comment 2 2013-02-16 21:50:30 PST
Comment on attachment 188753 [details] Patch Attachment 188753 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16590745 New failing tests: media/video-controls-captions-trackmenu.html
Andreas Kling
Comment 3 2013-02-16 22:03:29 PST
Committed r143124: <http://trac.webkit.org/changeset/143124>
Chris Dumez
Comment 4 2013-02-17 07:06:54 PST
The output of plugins/plugin-javascript-access.html changed after this patch it seems: --- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/plugins/plugin-javascript-access-expected.txt +++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/plugins/plugin-javascript-access-actual.txt @@ -1,3 +1,37 @@ +Name: WebKit Test PlugIn + +Description: Simple Netscape® plug-in that handles test content for WebKit + +Filename: libTestNetscapePlugin.so + +Mime Types: + +Type: application/x-webkit-test-netscape + +Description: test netscape content + +Suffixes: testnetscape + + +Plugin.item() works. + +Plugin.namedItem() works. + +Type: image/png + +Description: png image + +Suffixes: png + + +Plugin.item() works. + +Plugin.namedItem() works. + +PluginArray.item() works. + +PluginArray.namedItem() works. + Name: WebKit Test PlugIn Description: Simple Netscape® plug-in that handles test content for WebKit @@ -41,3 +75,13 @@ MimeTypeArray.item() works. MimeTypeArray.namedItem() works. + +Type: application/x-webkit-test-netscape + +Description: test netscape content + +Suffixes: testnetscape + +MimeTypeArray.item() works. + +MimeTypeArray.namedItem() works. Based on the patch description, I would not expect the behavior to change. Any idea why this happens?
Chris Dumez
Comment 5 2013-02-17 07:18:19 PST
I uploaded a fix for the regression at Bug 110053.
Note You need to log in before you can comment on or make changes to this bug.