Bug 110044 – Deprecate canvas.webkitLineDash and canvas.webkitLineDashOffset

• Status: NEW
• Component: Canvas

[Dirk Schulze]

Deprecate canvas.webkitLineDash and canvas.webkitLineDashOffset and throw warnings.

[Dirk Schulze]

Created attachment 188747 [details]
Patch

[Build Bot]

Comment on attachment 188747 [details]
Patch

Attachment 188747 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16549056

New failing tests:
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html
media/video-controls-captions-trackmenu.html
inspector/profiler/canvas2d/canvas2d-gradient-capturing.html

[Build Bot]

Comment on attachment 188747 [details]
Patch

Attachment 188747 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16608824

New failing tests:
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html
inspector/profiler/canvas2d/canvas2d-gradient-capturing.html

[Mike West]

Comment on attachment 188747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188747&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:554
> +        (ASCIILiteral("The attribute webkitLineDash is deprecated. Please use the methods setLineDash and getLineDash instead.")));

For consistency with other messages, I'd suggest putting code inside quotes. That is, "The attribute 'webkitLineDash' is deprecated...".

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:584
> +        (ASCIILiteral("The attribute webkitLineDashOffset is deprecated. Please use the attriubte lineDashOffset instead.")));

Nit: There's a typo in the second occurance of 'attribute'. :)

This also might sound slightly better as "The 'webkitLineDashOffset' attribute is deprecated. Please use 'lineDashOffset' instead."

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:593
> +        (ASCIILiteral("The attribute webkitLineDashOffset is deprecated. Please use the attriubte lineDashOffset instead.")));

Ditto.

[Dirk Schulze]

WebKit still has canvas.webkitLineDash. Is this bug still relevant? Do we need to give the deprecation warning still?