RESOLVED FIXED 110042
Make a few style tweaks to StringHasher.h 
https://bugs.webkit.org/show_bug.cgi?id=110042
Summary Make a few style tweaks to StringHasher.h
Darin Adler
Reported 2013-02-16 16:52:11 PST
Reduce use of abbreviations in StringHasher.h
Attachments
Patch (6.36 KB, patch)
2013-02-16 17:11 PST, Darin Adler 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2013-02-16 17:11:26 PST
Created attachment 188744 [details] Patch
Alexey Proskuryakov
Comment 2 2013-02-17 13:07:54 PST
Comment on attachment 188744 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188744&action=review > Source/WTF/wtf/StringHasher.h:210 > + // FIXME: Why does this function use the version of the hash that drops the top 8 bits? I don't really know the answer, but it's probably somewhere between these two comments in this file: // Reserving space from the high bits for flags preserves most of the hash's // value, since hash lookup typically masks out the high bits anyway. and // NOTE: This class must stay in sync with the create_hash_table script in // JavaScriptCore and the CodeGeneratorJS.pm script in WebCore. I also suspect that these reasons don't apply to callers of hashMemory, and this behavior is a result of a series of careless past refactorings.
Darin Adler
Comment 3 2013-02-18 17:46:42 PST
Committed r143280: <http://trac.webkit.org/changeset/143280>
Note You need to log in before you can comment on or make changes to this bug.