Bug 110038 - Stop passing around SelectorChecker in SelectorQuery, now that SelectorChecker is stack-allocated.
Summary: Stop passing around SelectorChecker in SelectorQuery, now that SelectorChecke...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 89879
  Show dependency treegraph
 
Reported: 2013-02-16 16:17 PST by Dimitri Glazkov (Google)
Modified: 2013-02-17 22:45 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.57 KB, patch)
2013-02-16 16:19 PST, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff
Patch for landing (6.48 KB, patch)
2013-02-16 16:50 PST, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2013-02-16 16:17:05 PST
Stop passing around SelectorChecker, now that it's stack-allocated.
Comment 1 Dimitri Glazkov (Google) 2013-02-16 16:19:59 PST
Created attachment 188738 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2013-02-16 16:48:32 PST
Comment on attachment 188738 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188738&action=review

> Source/WebCore/dom/SelectorQuery.cpp:67
> +    SelectorChecker selectorChecker(rootNode->document(), SelectorChecker::QueryingRules);

Eerk. This is not needed either. Will fix.
Comment 3 Dimitri Glazkov (Google) 2013-02-16 16:50:13 PST
Created attachment 188743 [details]
Patch for landing
Comment 4 WebKit Review Bot 2013-02-17 22:45:53 PST
Comment on attachment 188743 [details]
Patch for landing

Clearing flags on attachment: 188743

Committed r143152: <http://trac.webkit.org/changeset/143152>
Comment 5 WebKit Review Bot 2013-02-17 22:45:57 PST
All reviewed patches have been landed.  Closing bug.