RESOLVED FIXED 110034
Need a bundle SPI to generate a snapshot of a specific DOM node 
https://bugs.webkit.org/show_bug.cgi?id=110034
Summary Need a bundle SPI to generate a snapshot of a specific DOM node
Sam Weinig
Reported 2013-02-16 15:16:17 PST
Need a bundle SPI to generate a snapshot of a specific DOM node
Attachments
Patch (11.58 KB, patch)
2013-03-18 16:57 PDT, Sam Weinig 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-03-18 16:57:18 PDT
Created attachment 193693 [details] Patch
Tim Horton
Comment 2 2013-03-18 17:02:07 PDT
Comment on attachment 193693 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=193693&action=review > Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h:32 > -- (WKBundleNodeHandleRef)_copyWKBundleNodeHandleRef; > +- (WKBundleNodeHandleRef)_copyBundleNodeHandleRef; Is nobody going to mind this? > Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:132 > + OwnPtr<WebCore::GraphicsContext> graphicsContext = snapshot->bitmap()->createGraphicsContext(); Drop the WebCore::, I think.
Sam Weinig
Comment 3 2013-03-18 17:06:08 PDT
(In reply to comment #2) > (From update of attachment 193693 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=193693&action=review > > > Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMNodePrivate.h:32 > > -- (WKBundleNodeHandleRef)_copyWKBundleNodeHandleRef; > > +- (WKBundleNodeHandleRef)_copyBundleNodeHandleRef; > > Is nobody going to mind this? It was mismatched from the implementation :(. > > > Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:132 > > + OwnPtr<WebCore::GraphicsContext> graphicsContext = snapshot->bitmap()->createGraphicsContext(); > > Drop the WebCore::, I think. K.
Sam Weinig
Comment 4 2013-03-18 17:22:04 PDT
Committed r146154: <http://trac.webkit.org/changeset/146154>
Note You need to log in before you can comment on or make changes to this bug.