Cut down the number of source files that depend on Clipboard.h
Created attachment 188733 [details] Patch
Comment on attachment 188733 [details] Patch Attachment 188733 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16587715
In file included from /home/webkit/WebKit/Source/WebCore/inspector/InspectorInputAgent.cpp:38:0: /home/webkit/WebKit/Source/WebCore/page/EventHandler.h:467:12: error: 'Document' was not declared in this scope /home/webkit/WebKit/Source/WebCore/page/EventHandler.h:467:20: error: template argument 1 is invalid
So it seems that on my local Mac and on the GTK EWS bot the patch builds, but on Qt, Chromium-Android, and others there is a missing forward declaration of Document in EventHandler.h.
Created attachment 188740 [details] Patch
Letting EWS chew on this before formally putting a version up for review this time.
Comment on attachment 188740 [details] Patch Qt liked it, so putting up for review again.
Comment on attachment 188740 [details] Patch Attachment 188740 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://queues.webkit.org/results/16586806 New failing tests: media/video-controls-captions-trackmenu.html
Comment on attachment 188740 [details] Patch Attachment 188740 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/16598706
Comment on attachment 188740 [details] Patch Attachment 188740 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16587974
(In reply to comment #10) > (From update of attachment 188740 [details]) > Attachment 188740 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/16587974 Last 500 characters of output: ource/WebKit/chromium/src/SharedWorkerRepository.cpp: In member function 'virtual void WebCore::SharedWorkerScriptLoader::didReceiveResponse(long unsigned int, const WebCore::ResourceResponse&)': ../../Source/WebKit/chromium/src/SharedWorkerRepository.cpp:179: error: invalid use of incomplete type 'const struct WebCore::ResourceResponse' ../../Source/WebCore/loader/PolicyChecker.h:46: error: forward declaration of 'const struct WebCore::ResourceResponse' ninja: build stopped: subcommand failed. It's somewhat mind blowing that SharedWorkerRepository.cpp depends on ResourceResponse, and it was including Clipboard.h :(
Attachment 188740 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/dom/ClipboardEvent.cpp', u'Source/WebCore/dom/ClipboardEvent.h', u'Source/WebCore/dom/DataTransferItem.h', u'Source/WebCore/dom/MouseEvent.cpp', u'Source/WebCore/dom/MouseEvent.h', u'Source/WebCore/dom/WheelEvent.cpp', u'Source/WebCore/dom/WheelEvent.h', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/loader/PingLoader.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.h', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebPDFView.mm']" exit_code: 1 Source/WebCore/dom/ClipboardEvent.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 188740 [details] Patch Attachment 188740 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16602807
Created attachment 188971 [details] Patch
Attachment 188971 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/dom/ClipboardEvent.cpp', u'Source/WebCore/dom/ClipboardEvent.h', u'Source/WebCore/dom/DataTransferItem.h', u'Source/WebCore/dom/MouseEvent.cpp', u'Source/WebCore/dom/MouseEvent.h', u'Source/WebCore/dom/WheelEvent.cpp', u'Source/WebCore/dom/WheelEvent.h', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/inspector/InspectorDebuggerAgent.cpp', u'Source/WebCore/inspector/InspectorFrontendHost.cpp', u'Source/WebCore/inspector/NetworkResourcesData.cpp', u'Source/WebCore/loader/PingLoader.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.h', u'Source/WebKit/chromium/ChangeLog', u'Source/WebKit/chromium/src/SharedWorkerRepository.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebPDFView.mm']" exit_code: 1 Source/WebCore/dom/ClipboardEvent.h:31: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 188971 [details] Patch Attachment 188971 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16654073 New failing tests: http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
Committed r144553: <http://trac.webkit.org/changeset/144553>