Bug 109997 – [Chromium] Add runtime flag for CanvasPath

• Status: RESOLVED
• Resolution: FIXED
• Component: Canvas

[Dirk Schulze]

Add runtime flag for CanvasPath on Chromium.

[Dirk Schulze]

Created attachment 188681 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Eric Seidel (no email)]

I'm surprised more of this isn't autogenerated.  Looks reasonable to me.

[WebKit Review Bot]

Comment on attachment 188681 [details]
Patch

Attachment 188681 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16595445

New failing tests:
inspector/profiler/canvas2d/canvas2d-api-changes.html

[Dirk Schulze]

Created attachment 188698 [details]
Patch

[Darin Fisher (:fishd, Google)]

Chromium WebKit API changes look good to me.

[Adam Barth]

Comment on attachment 188698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188698&action=review

> LayoutTests/platform/chromium/TestExpectations:4352
> +webkit.org/b/108508 inspector/profiler/canvas2d/canvas2d-api-changes.html [ Failure ]

Rather than skipping this test, we should probably update the baseline.

[Adam Barth]

Comment on attachment 188698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188698&action=review

> Tools/DumpRenderTree/chromium/TestShell.cpp:153
> +    WebRuntimeFeatures::enableCanvasPath(true);

Presumably we should now pass some tests relating to paths.  There should be some red lines in TestExpectations because of this change.

[Dirk Schulze]

I wanted to do that with fixing bug 108508 (enabling the compiler flag). I can land the patches right after each other. So that this will be fixed immediately. This includes fixes for the other tests that are skipped right now as well.

[Adam Barth]

Comment on attachment 188698 [details]
Patch

ok

[Adam Barth]

Comment on attachment 188698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188698&action=review

> Source/WebKit/chromium/features.gypi:39
> -      'ENABLE_CANVAS_PATH=0',
> +      'ENABLE_CANVAS_PATH=1',

I thought this patch enabled the compiler flag as well, but maybe I'm confused.

[Dirk Schulze]

(In reply to comment #11)
> (From update of attachment 188698 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=188698&action=review
> 
> > Source/WebKit/chromium/features.gypi:39
> > -      'ENABLE_CANVAS_PATH=0',
> > +      'ENABLE_CANVAS_PATH=1',
> 
> I thought this patch enabled the compiler flag as well, but maybe I'm confused.

I agree. This does enable it, but just for Chromium. I will remove this flag from this patch, but still wait for landing until a patch for bug 108508 got accepted - if that is ok for you.

[Adam Barth]

That's fine.  I'm not trying to give you a hard time.  Just seeking to understand.

[Dirk Schulze]

Committed r143502: <http://trac.webkit.org/changeset/143502>