Bug 109957 - Remove const from a bunch of StorageArea member functions
Summary: Remove const from a bunch of StorageArea member functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 11:25 PST by Anders Carlsson
Modified: 2013-02-15 12:07 PST (History)
3 users (show)

See Also:


Attachments
Patch (18.52 KB, patch)
2013-02-15 11:27 PST, Anders Carlsson
bdakin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-02-15 11:25:59 PST
Remove const from a bunch of StorageArea member functions
Comment 1 Anders Carlsson 2013-02-15 11:27:51 PST
Created attachment 188606 [details]
Patch
Comment 2 Andreas Kling 2013-02-15 11:55:49 PST
I think that this removes useful documentation from the code about which functions on the StorageArea interface are conceptually read-only. :(
Comment 3 Anders Carlsson 2013-02-15 11:59:01 PST
(In reply to comment #2)
> I think that this removes useful documentation from the code about which functions on the StorageArea interface are conceptually read-only. :(

I don’t think it makes much sense to use const for an abstract class where implementations can do pretty much anything. That’s the reason why none of our client member functions are const.
Comment 4 Anders Carlsson 2013-02-15 12:07:33 PST
Committed r143031: <http://trac.webkit.org/changeset/143031>