RESOLVED FIXED 109957
Remove const from a bunch of StorageArea member functions 
https://bugs.webkit.org/show_bug.cgi?id=109957
Summary Remove const from a bunch of StorageArea member functions
Anders Carlsson
Reported 2013-02-15 11:25:59 PST
Remove const from a bunch of StorageArea member functions
Attachments
Patch (18.52 KB, patch)
2013-02-15 11:27 PST, Anders Carlsson 		bdakin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-02-15 11:27:51 PST
Created attachment 188606 [details] Patch
Andreas Kling
Comment 2 2013-02-15 11:55:49 PST
I think that this removes useful documentation from the code about which functions on the StorageArea interface are conceptually read-only. :(
Anders Carlsson
Comment 3 2013-02-15 11:59:01 PST
(In reply to comment #2) > I think that this removes useful documentation from the code about which functions on the StorageArea interface are conceptually read-only. :( I don’t think it makes much sense to use const for an abstract class where implementations can do pretty much anything. That’s the reason why none of our client member functions are const.
Anders Carlsson
Comment 4 2013-02-15 12:07:33 PST
Committed r143031: <http://trac.webkit.org/changeset/143031>
Note You need to log in before you can comment on or make changes to this bug.