Bug 109930 - Web Inspector: highlight record revealed in Timeline
Summary: Web Inspector: highlight record revealed in Timeline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 05:41 PST by Yury Semikhatsky
Modified: 2013-02-15 07:49 PST (History)
8 users (show)

See Also:

Attachments
Patch (4.39 KB, patch)
2013-02-15 05:42 PST, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2013-02-15 05:41:04 PST 
If user clicks on the memory graph, corresponding record is revealed in the viewport above but it is hard to tell which record exactly was revealed. Highlighting it would make the record more prominent.
Comment 1 Yury Semikhatsky 2013-02-15 05:42:33 PST 
Created attachment 188547 [details]
Patch
Comment 2 Ilya Tikhonovsky 2013-02-15 06:04:57 PST 
Comment on attachment 188547 [details]
Patch

lgtm
Comment 3 Pavel Feldman 2013-02-15 06:07:58 PST 
Comment on attachment 188547 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188547&action=review

> Source/WebCore/inspector/front-end/TimelinePanel.js:940
> +        this._highlightedListRowElement = null;

delete this._highlightedListRowElement
Comment 4 Yury Semikhatsky 2013-02-15 07:49:10 PST 
Committed r142999: <http://trac.webkit.org/changeset/142999>