Bug 109925 - [WK2] Refactoring : Fix indentation and braces in WebInspectorClient.h|cpp
Summary: [WK2] Refactoring : Fix indentation and braces in WebInspectorClient.h|cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-15 04:44 PST by Seokju Kwon
Modified: 2013-02-28 20:41 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.25 KB, patch)
2013-02-15 04:46 PST, Seokju Kwon 		no flags Details | Formatted Diff | Diff
Patch (2.23 KB, patch)
2013-02-15 17:50 PST, Seokju Kwon 		no flags Details | Formatted Diff | Diff
Patch (2.17 KB, patch)
2013-02-28 19:59 PST, Seokju Kwon 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Seokju Kwon 2013-02-15 04:44:09 PST 
The contents of an outermost namespace block should not be indented.                                                                
And One-line control clauses should not use braces.
(http://www.webkit.org/coding/coding-style.html)
Comment 1 Seokju Kwon 2013-02-15 04:46:41 PST 
Created attachment 188537 [details]
Patch
Comment 2 Build Bot 2013-02-15 10:10:14 PST 
Comment on attachment 188537 [details]
Patch

Attachment 188537 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16598130

New failing tests:
http/tests/inspector/resource-tree/resource-request-content-while-loading.html
Comment 3 Seokju Kwon 2013-02-15 17:50:22 PST 
Created attachment 188678 [details]
Patch
Comment 4 Seokju Kwon 2013-02-28 19:59:59 PST 
Created attachment 190872 [details]
Patch
Comment 5 Seokju Kwon 2013-02-28 20:00:24 PST 
Comment on attachment 190872 [details]
Patch

rebased
Comment 6 Seokju Kwon 2013-02-28 20:04:16 PST 
@benjamin Could you take a loot at it? It's a simple thing.
Comment 7 Benjamin Poulain 2013-02-28 20:04:44 PST 
Comment on attachment 190872 [details]
Patch

Why not.
Comment 8 WebKit Review Bot 2013-02-28 20:41:48 PST 
Comment on attachment 190872 [details]
Patch

Clearing flags on attachment: 190872

Committed r144411: <http://trac.webkit.org/changeset/144411>
Comment 9 WebKit Review Bot 2013-02-28 20:41:51 PST 
All reviewed patches have been landed.  Closing bug.