Bug 109919 – Web Inspector: Merge Debug and Tip message levels.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Dmitry Zvorygin]

Merge "Debug" and "Tip" message levels, since most of components using any of this message levels use only either Tip or Debug.

[Dmitry Zvorygin]

Created attachment 189077 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[Dmitry Zvorygin]

Created attachment 189078 [details]
Patch

[Pavel Feldman]

Comment on attachment 189078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189078&action=review

> Source/WebKit/chromium/public/WebConsoleMessage.h:40
> +        LevelTip = 0,

Why is tip not removed?

[Dmitry Zvorygin]

Comment on attachment 189078 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=189078&action=review

>> Source/WebKit/chromium/public/WebConsoleMessage.h:40
>> +        LevelTip = 0,
> 
> Why is tip not removed?

Because chromium code depends on it. I've removed all the usages from both chromium and webkit, but if I remove it before webkit roll, chromium builds start failing.

There will be small third changelist, which will remove this very last LevelTip declaration, and remove enum fields wierd reordering. Third changelist should be pushed synchronously in webkit and chromium.

[Dmitry Zvorygin]

Created attachment 189508 [details]
Patch

[WebKit Review Bot]

Comment on attachment 189508 [details]
Patch

Rejecting attachment 189508 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 189508, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:

fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2

Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2
Updating OpenSource
fatal: read error: Connection reset by peer
Died at Tools/Scripts/update-webkit line 151.

Full output: http://queues.webkit.org/results/16691794

[Dmitry Zvorygin]

Created attachment 190279 [details]
Patch

[WebKit Review Bot]

Comment on attachment 190279 [details]
Patch

Clearing flags on attachment: 190279

Committed r144064: <http://trac.webkit.org/changeset/144064>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.