Bug 109905 - Calculate EventPath in EventDispatcher's constructor.
Summary: Calculate EventPath in EventDispatcher's constructor.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on: 109898
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-15 00:14 PST by Hayato Ito
Modified: 2013-02-19 19:07 PST (History)
5 users (show)

See Also:

Attachments
Calculates an EventPath in the constructor (7.20 KB, patch)
2013-02-15 00:19 PST, Hayato Ito 		no flags Details | Formatted Diff | Diff
Patch for landing (7.20 KB, patch)
2013-02-17 22:36 PST, Hayato Ito 		no flags Details | Formatted Diff | Diff
Patch for landing (7.24 KB, patch)
2013-02-19 02:58 PST, Hayato Ito 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2013-02-15 00:14:00 PST 
I can not find any reason to initialize an EventPath lazily.
We can calculate an EventPath in EventDispatcher's constructor and remove EventDispatcher::ensureEventPath() after bug 109898 is fixed.
Comment 1 Hayato Ito 2013-02-15 00:19:08 PST 
Created attachment 188496 [details]
Calculates an EventPath in the constructor
Comment 2 Hayato Ito 2013-02-15 00:20:21 PST 
The uploaded patch depends on the patch in bug 109898.
Comment 3 Hayato Ito 2013-02-17 22:36:19 PST 
Created attachment 188798 [details]
Patch for landing
Comment 4 WebKit Review Bot 2013-02-17 23:29:04 PST 
Comment on attachment 188798 [details]
Patch for landing

Rejecting attachment 188798 [details] from commit-queue.

New failing tests:
fast/events/touch/gesture/pad-gesture-cancel.html
Full output: http://queues.webkit.org/results/16610104
Comment 5 Hayato Ito 2013-02-17 23:38:06 PST 
Hmm. 

fast/events/touch/gesture/pad-gesture-cancel.html has been crashed without this patch locally.
Let me retry cq+.

(In reply to comment #4)
> (From update of attachment 188798 [details])
> Rejecting attachment 188798 [details] from commit-queue.
> 
> New failing tests:
> fast/events/touch/gesture/pad-gesture-cancel.html
> Full output: http://queues.webkit.org/results/16610104
Comment 6 WebKit Review Bot 2013-02-18 00:34:54 PST 
Comment on attachment 188798 [details]
Patch for landing

Rejecting attachment 188798 [details] from commit-queue.

New failing tests:
fast/events/touch/gesture/pad-gesture-cancel.html
Full output: http://queues.webkit.org/results/16545079
Comment 7 WebKit Review Bot 2013-02-18 00:48:59 PST 
Comment on attachment 188798 [details]
Patch for landing

Attachment 188798 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16613055

New failing tests:
fast/events/touch/gesture/pad-gesture-cancel.html
Comment 8 Hayato Ito 2013-02-19 02:58:20 PST 
Created attachment 189034 [details]
Patch for landing
Comment 9 Hayato Ito 2013-02-19 02:59:08 PST 
Let me cq+ tomorrow to watch the result.

(In reply to comment #8)
> Created an attachment (id=189034) [details]
> Patch for landing
Comment 10 WebKit Review Bot 2013-02-19 19:07:15 PST 
Comment on attachment 189034 [details]
Patch for landing

Clearing flags on attachment: 189034

Committed r143426: <http://trac.webkit.org/changeset/143426>
Comment 11 WebKit Review Bot 2013-02-19 19:07:20 PST 
All reviewed patches have been landed.  Closing bug.