Bug 109903 - [chromium] clean up TestRunner API
Summary: [chromium] clean up TestRunner API
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 110013
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-14 23:54 PST by jochen
Modified: 2013-04-08 16:30 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-02-14 23:54:02 PST 
- add comments to the public methods
- make WebTestDelegate methods all pure virtual
- TestInterfaces setup is brittle:
  - setWebView should check that the webview and the proxy are either both non-zero or both zero
  - the constructor should resetAll()
  - it doesn't make sense to set the delegate separately from the webview/proxy - should probably be just one method