Bug 109901 - [chromium] WebInputEventBuilders should not reverse page scale
Summary: [chromium] WebInputEventBuilders should not reverse page scale
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandre Elias
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-14 23:41 PST by Alexandre Elias
Modified: 2013-02-15 12:37 PST (History)
4 users (show)

See Also:

Attachments
Patch (9.89 KB, patch)
2013-02-14 23:44 PST, Alexandre Elias 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Elias 2013-02-14 23:41:58 PST 
[chromium] WebInputEventBuilders should not reverse page scale
Comment 1 Alexandre Elias 2013-02-14 23:44:56 PST 
Created attachment 188493 [details]
Patch
Comment 2 Alexandre Elias 2013-02-14 23:48:47 PST 
The lack of idempotence is unfortunate, but this is what turns out to actually work.
Comment 3 James Robinson 2013-02-15 10:50:12 PST 
Comment on attachment 188493 [details]
Patch

Hmmmm....odd, but them's the breaks I guess.  Longer-term, do you think we should move the page scale adjustements for plugins somewhere else in the stack?
Comment 4 Alexandre Elias 2013-02-15 12:02:35 PST 
It's not clear to me what would be cleaner long-term... plugins are reusing WebInputEvents just because it lets them get the information back across to the Chromium side.  But even in the absence of page scale, the fields in them don't have the same meaning -- the scroll origin is the origin of the plugin, not the window scroll position.
Comment 5 WebKit Review Bot 2013-02-15 12:37:15 PST 
Comment on attachment 188493 [details]
Patch

Clearing flags on attachment: 188493

Committed r143032: <http://trac.webkit.org/changeset/143032>
Comment 6 WebKit Review Bot 2013-02-15 12:37:18 PST 
All reviewed patches have been landed.  Closing bug.