Bug 109897 – Add setValue and closePopup methods to PagePopupController

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Keishi Hattori]

In the new calendar picker, we want to set a value without closing the popup.

[Keishi Hattori]

Created attachment 188490 [details]
Patch

[Kent Tamura]

Comment on attachment 188490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188490&action=review

> Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:173
> -    RefPtr<DateTimeChooserImpl> protector(this);
>      if (numValue >= 0)
> -        m_client->didChooseValue(stringValue);
> +        setValue(stringValue);
> +    endChooser();
> +}

The protector is required here.  setValue(), which might dispatch some events, can delete 'this'.

> Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:178
> +    RefPtr<DateTimeChooserImpl> protector(this);
> +    m_client->didChooseValue(value);

The protector makes no sense. We do nothing after didChooseValue, which might dispatch some events.
Also, I'm afraid that we have no ways to avoid calendar picker JavaScript code execution after didChooseValue because event handler might delete the page popup.

[Keishi Hattori]

Created attachment 188529 [details]
changed protector position

[Kent Tamura]

Comment on attachment 188529 [details]
changed protector position

ok

[WebKit Review Bot]

Comment on attachment 188529 [details]
changed protector position

Clearing flags on attachment: 188529

Committed r142987: <http://trac.webkit.org/changeset/142987>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.