WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
109885
[WK2] Rename from scrollOffset to scrollDelta in WebChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=109885
Summary
[WK2] Rename from scrollOffset to scrollDelta in WebChromeClient.
Dongseong Hwang
Reported
2013-02-14 21:04:46 PST
Chrome sends a scroll delta to WebChromeClient but WebChromeClient names it scrollOffset. So this patch corrects this misnaming. In addition, all subclasses of LayerTreeHost don't use the misnamed scrollOffset in scrollNonCompositedContents(), so this patch removes the scrollOffset argument.
Attachments
Patch
(17.06 KB, patch)
2013-02-14 21:07 PST
,
Dongseong Hwang
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dongseong Hwang
Comment 1
2013-02-14 21:07:01 PST
Created
attachment 188475
[details]
Patch
WebKit Review Bot
Comment 2
2013-02-14 23:16:42 PST
Comment on
attachment 188475
[details]
Patch Clearing flags on attachment: 188475 Committed
r142968
: <
http://trac.webkit.org/changeset/142968
>
WebKit Review Bot
Comment 3
2013-02-14 23:16:45 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug