Bug 109883 - Add support for testing states changing asynchronously. Apply it to state-url-sets-links-visited.html.
Summary: Add support for testing states changing asynchronously. Apply it to state-url...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on: 110613
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-14 20:38 PST by Benjamin Poulain
Modified: 2013-02-23 23:26 PST (History)
8 users (show)

See Also:


Attachments
Patch (8.83 KB, patch)
2013-02-14 20:53 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (8.83 KB, patch)
2013-02-21 12:54 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (11.68 KB, patch)
2013-02-21 15:31 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (11.84 KB, patch)
2013-02-23 18:25 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-02-14 20:38:35 PST
Add support for testing states changing asynchronously. Apply it to state-url-sets-links-visited.html.
Comment 1 Benjamin Poulain 2013-02-14 20:53:17 PST
Created attachment 188472 [details]
Patch
Comment 2 Benjamin Poulain 2013-02-14 20:54:16 PST
What do you think?
If that sounds okay, I will update the other tests failing on computedStyleIncludingVisitedInfo.
Comment 3 Benjamin Poulain 2013-02-20 21:13:38 PST
Any opinion anyone?
Comment 4 Antti Koivisto 2013-02-21 09:26:29 PST
Comment on attachment 188472 [details]
Patch

seems ok to me
Comment 5 Benjamin Poulain 2013-02-21 12:54:55 PST
Created attachment 189581 [details]
Patch
Comment 6 WebKit Review Bot 2013-02-21 13:58:49 PST
Comment on attachment 189581 [details]
Patch

Attachment 189581 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16693292

New failing tests:
fast/loader/stateobjects/state-url-sets-links-visited.html
Comment 7 Benjamin Poulain 2013-02-21 15:31:23 PST
Created attachment 189619 [details]
Patch
Comment 8 Benjamin Poulain 2013-02-21 18:31:17 PST
Comment on attachment 189619 [details]
Patch

Clearing flags on attachment: 189619

Committed r143678: <http://trac.webkit.org/changeset/143678>
Comment 9 Benjamin Poulain 2013-02-21 18:31:20 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Vsevolod Vlasov 2013-02-22 01:06:36 PST
fast/loader/stateobjects/state-url-sets-links-visited.html is timing out in chromium after this patch: https://bugs.webkit.org/show_bug.cgi?id=110566

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Floader%2Fstateobjects%2Fstate-url-sets-links-visited.html
Comment 11 WebKit Review Bot 2013-02-22 08:46:51 PST
Re-opened since this is blocked by bug 110613
Comment 12 Benjamin Poulain 2013-02-23 18:25:00 PST
Created attachment 189947 [details]
Patch
Comment 13 Benjamin Poulain 2013-02-23 23:26:13 PST
Committed r143860: <http://trac.webkit.org/changeset/143860>