RESOLVED FIXED 109883
Add support for testing states changing asynchronously. Apply it to state-url-sets-links-visited.html. 
https://bugs.webkit.org/show_bug.cgi?id=109883
Summary Add support for testing states changing asynchronously. Apply it to state-url...
Benjamin Poulain
Reported 2013-02-14 20:38:35 PST
Add support for testing states changing asynchronously. Apply it to state-url-sets-links-visited.html.
Attachments
Patch (8.83 KB, patch)
2013-02-14 20:53 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (8.83 KB, patch)
2013-02-21 12:54 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (11.68 KB, patch)
2013-02-21 15:31 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (11.84 KB, patch)
2013-02-23 18:25 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-02-14 20:53:17 PST
Created attachment 188472 [details] Patch
Benjamin Poulain
Comment 2 2013-02-14 20:54:16 PST
What do you think? If that sounds okay, I will update the other tests failing on computedStyleIncludingVisitedInfo.
Benjamin Poulain
Comment 3 2013-02-20 21:13:38 PST
Any opinion anyone?
Antti Koivisto
Comment 4 2013-02-21 09:26:29 PST
Comment on attachment 188472 [details] Patch seems ok to me
Benjamin Poulain
Comment 5 2013-02-21 12:54:55 PST
Created attachment 189581 [details] Patch
WebKit Review Bot
Comment 6 2013-02-21 13:58:49 PST
Comment on attachment 189581 [details] Patch Attachment 189581 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16693292 New failing tests: fast/loader/stateobjects/state-url-sets-links-visited.html
Benjamin Poulain
Comment 7 2013-02-21 15:31:23 PST
Created attachment 189619 [details] Patch
Benjamin Poulain
Comment 8 2013-02-21 18:31:17 PST
Comment on attachment 189619 [details] Patch Clearing flags on attachment: 189619 Committed r143678: <http://trac.webkit.org/changeset/143678>
Benjamin Poulain
Comment 9 2013-02-21 18:31:20 PST
All reviewed patches have been landed. Closing bug.
Vsevolod Vlasov
Comment 10 2013-02-22 01:06:36 PST
fast/loader/stateobjects/state-url-sets-links-visited.html is timing out in chromium after this patch: https://bugs.webkit.org/show_bug.cgi?id=110566 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Floader%2Fstateobjects%2Fstate-url-sets-links-visited.html
WebKit Review Bot
Comment 11 2013-02-22 08:46:51 PST
Re-opened since this is blocked by bug 110613
Benjamin Poulain
Comment 12 2013-02-23 18:25:00 PST
Created attachment 189947 [details] Patch
Benjamin Poulain
Comment 13 2013-02-23 23:26:13 PST
Committed r143860: <http://trac.webkit.org/changeset/143860>
Note You need to log in before you can comment on or make changes to this bug.