Bug 109881 - Implement RenderGrid::computeIntrinsicLogicalWidths
Summary: Implement RenderGrid::computeIntrinsicLogicalWidths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on: 109880
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-14 18:44 PST by Ojan Vafai
Modified: 2013-02-15 13:19 PST (History)
2 users (show)

See Also:


Attachments
Patch (4.56 KB, patch)
2013-02-14 18:47 PST, Ojan Vafai
no flags Details | Formatted Diff | Diff
Patch (5.46 KB, patch)
2013-02-15 12:34 PST, Ojan Vafai
tony: review+
tony: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2013-02-14 18:44:44 PST
Implement RenderGrid::computeIntrinsicLogicalWidths
Comment 1 Ojan Vafai 2013-02-14 18:47:35 PST
Created attachment 188464 [details]
Patch
Comment 2 Ojan Vafai 2013-02-14 18:48:14 PST
Bug 109880 was done in preparation for this.
Comment 3 Ojan Vafai 2013-02-15 12:34:01 PST
Created attachment 188619 [details]
Patch
Comment 4 Tony Chang 2013-02-15 12:39:37 PST
Comment on attachment 188619 [details]
Patch

Now that I've seen the code, I think a const_cast of |this| in computeIntrinsicLogicalWidths would be better.  It feels weird to me that placeItemsOnGrid is const.
Comment 5 Ojan Vafai 2013-02-15 13:19:59 PST
Committed r143043: <http://trac.webkit.org/changeset/143043>