Bug 109872 - Inspector doesn't show rules from pluginsStyleSheet
Summary: Inspector doesn't show rules from pluginsStyleSheet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-02-14 16:06 PST by Dean Jackson
Modified: 2013-02-14 17:22 PST (History)
15 users (show)

See Also:

Attachments
Patch (1.93 KB, patch)
2013-02-14 16:09 PST, Dean Jackson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-02-14 16:06:09 PST 
The inspector doesn't collect the rules from the plugins style sheet.
Comment 1 Radar WebKit Bug Importer 2013-02-14 16:06:49 PST 
<rdar://problem/13220679>
Comment 2 Dean Jackson 2013-02-14 16:09:19 PST 
Created attachment 188446 [details]
Patch
Comment 3 Darin Adler 2013-02-14 16:44:28 PST 
Comment on attachment 188446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188446&action=review

> Source/WebCore/css/InspectorCSSOMWrappers.cpp:127
> +        collectFromStyleSheetContents(m_styleSheetCSSOMWrapperSet, CSSDefaultStyleSheets::plugInsStyleSheet);

No #ifdef needed?
Comment 4 Dean Jackson 2013-02-14 17:13:37 PST 
Comment on attachment 188446 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188446&action=review

>> Source/WebCore/css/InspectorCSSOMWrappers.cpp:127
>> +        collectFromStyleSheetContents(m_styleSheetCSSOMWrapperSet, CSSDefaultStyleSheets::plugInsStyleSheet);
> 
> No #ifdef needed?

Nope - these default stylesheets are always around (although possibly empty, and can have different content on different ports thanks to #ifdefs in CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement).
Comment 5 Dean Jackson 2013-02-14 17:22:15 PST 
Committed r142944: <http://trac.webkit.org/changeset/142944>