RESOLVED FIXED 109863
[BlackBerry] Make sure to always sync before reusing backingstore tiles 
https://bugs.webkit.org/show_bug.cgi?id=109863
Summary [BlackBerry] Make sure to always sync before reusing backingstore tiles
Jakob Petsovits
Reported 2013-02-14 14:22:19 PST
In SVN r142137, I replaced a syncToCurrentMessage() call with updateSuspendScreenUpdateState() in some cases, which internally calls the same function. Unfortunately, when I optimized updateSuspendScreenUpdateState() to only sync when the state is actually being changed, I omitted an adaptation of adoptAsFrontState() which would rely on this sync but now didn't always perform it. This caused a bad race condition as tile buffers could now be accessed from the WebKit thread and the UI thread at the same time. The patch below fixes it by (optionally) letting the caller of updateSuspendScreenUpdateState() know whether a sync was performed, and adapt adoptAsFrontState() accordingly.
Attachments
Patch (4.83 KB, patch)
2013-02-14 14:25 PST, Jakob Petsovits 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jakob Petsovits
Comment 1 2013-02-14 14:25:24 PST
Created attachment 188428 [details] Patch
Rob Buis
Comment 2 2013-02-14 14:30:56 PST
Comment on attachment 188428 [details] Patch Ok.
WebKit Review Bot
Comment 3 2013-02-19 14:55:16 PST
Comment on attachment 188428 [details] Patch Rejecting attachment 188428 [details] from commit-queue. New failing tests: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html Full output: http://queues.webkit.org/results/16621963
Jakob Petsovits
Comment 4 2013-02-20 08:25:23 PST
Comment on attachment 188428 [details] Patch This patch only affects two files in Source/WebKit/blackberry which are not known to the inside world of WebCore or any other port. It is therefore extremely unlikely that the patch breaks a Chromium test. Setting back to cq+, hopefully it'll work now.
WebKit Review Bot
Comment 5 2013-02-20 08:45:16 PST
Comment on attachment 188428 [details] Patch Clearing flags on attachment: 188428 Committed r143466: <http://trac.webkit.org/changeset/143466>
WebKit Review Bot
Comment 6 2013-02-20 08:45:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.