Bug 109861 - TokenPreloadScanner should be able to scan CompactHTMLTokens
Summary: TokenPreloadScanner should be able to scan CompactHTMLTokens
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 108027
  Show dependency tree / graph
 
Reported: 2013-02-14 14:15 PST by Adam Barth
Modified: 2013-02-15 11:13 PST (History)
9 users (show)

See Also:

Attachments
Patch (14.28 KB, patch)
2013-02-14 14:20 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (21.71 KB, patch)
2013-02-15 10:32 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-02-14 14:15:20 PST 
TokenPreloadScanner should be able to scan CompactHTMLTokens
Comment 1 Adam Barth 2013-02-14 14:20:20 PST 
Created attachment 188426 [details]
Patch
Comment 2 Early Warning System Bot 2013-02-14 14:32:43 PST 
Comment on attachment 188426 [details]
Patch

Attachment 188426 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/16581513
Comment 3 Early Warning System Bot 2013-02-14 14:33:29 PST 
Comment on attachment 188426 [details]
Patch

Attachment 188426 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/16538801
Comment 4 Adam Barth 2013-02-14 14:38:14 PST 
Probably needs moar ifdefs.  :)

I'd be interested in your review feedback, however.  I'll get it to compile before landing.
Comment 5 Eric Seidel (no email) 2013-02-14 14:39:08 PST 
Comment on attachment 188426 [details]
Patch

I'm entertained that you undid my processPossible refactoring. :)
Comment 6 Adam Barth 2013-02-14 14:49:09 PST 
> I'm entertained that you undid my processPossible refactoring. :)

Yeah, sorry about that.  I liked it, but it didn't play well with the switch statement.
Comment 7 EFL EWS Bot 2013-02-14 16:23:55 PST 
Comment on attachment 188426 [details]
Patch

Attachment 188426 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/16538845
Comment 8 Build Bot 2013-02-14 20:30:15 PST 
Comment on attachment 188426 [details]
Patch

Attachment 188426 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16537920
Comment 9 Build Bot 2013-02-15 05:08:59 PST 
Comment on attachment 188426 [details]
Patch

Attachment 188426 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16593082
Comment 10 Eric Seidel (no email) 2013-02-15 07:35:06 PST 
Comment on attachment 188426 [details]
Patch

OK.  Ugly switch. :(
Comment 11 Adam Barth 2013-02-15 10:32:07 PST 
Created attachment 188600 [details]
Patch for landing
Comment 12 WebKit Review Bot 2013-02-15 10:58:23 PST 
Comment on attachment 188600 [details]
Patch for landing

Rejecting attachment 188600 [details] from commit-queue.

abarth@webkit.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 13 Adam Barth 2013-02-15 11:03:09 PST 
wat?
Comment 14 Adam Barth 2013-02-15 11:13:10 PST 
Comment on attachment 188600 [details]
Patch for landing

Clearing flags on attachment: 188600

Committed r143020: <http://trac.webkit.org/changeset/143020>
Comment 15 Adam Barth 2013-02-15 11:13:13 PST 
All reviewed patches have been landed.  Closing bug.