Bug 109855 – [BlackBerry] requireAuth parameter of NetworkJob is redundant

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Joe Mason]

The requireAuth parameter of NetworkJob::notifyAuthReceived is redundant as its value can be determined from "result" - if result is AuthResultRetry, requireAuth is false, otherwise it is true. For code cleanup it should be removed.

[Joe Mason]

Created attachment 188430 [details]
fix

[Joe Mason]

Comment on attachment 188430 [details]
fix

changelog has the wrong PR number. Not sure how that happened

[Joe Mason]

Created attachment 188431 [details]
fix

[WebKit Review Bot]

Comment on attachment 188431 [details]
fix

Rejecting attachment 188431 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 188431, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
ile Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/platform/network/blackberry/NetworkJob.cpp
Hunk #2 FAILED at 355.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/network/blackberry/NetworkJob.cpp.rej
patching file Source/WebCore/platform/network/blackberry/NetworkJob.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Yong Li']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16542754

[Joe Mason]

Seems we forgot to upstream something.

[Joe Mason]

I didn't realize https://bugs.webkit.org/show_bug.cgi?id=109751 isn't reviewed and committed yet

[Joe Mason]

Created attachment 188442 [details]
rebased fix

[Build Bot]

Comment on attachment 188442 [details]
rebased fix

Attachment 188442 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16537922

New failing tests:
media/video-controls-captions-trackmenu.html

[WebKit Review Bot]

Comment on attachment 188442 [details]
rebased fix

Clearing flags on attachment: 188442

Committed r142996: <http://trac.webkit.org/changeset/142996>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.