Bug 109855 - [BlackBerry] requireAuth parameter of NetworkJob is redundant
Summary: [BlackBerry] requireAuth parameter of NetworkJob is redundant
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Unspecified
: P2 Minor
Assignee: Joe Mason
Depends on: 109751
  Show dependency treegraph
Reported: 2013-02-14 13:22 PST by Joe Mason
Modified: 2013-02-15 07:27 PST (History)
7 users (show)

See Also:

fix (4.22 KB, patch)
2013-02-14 14:33 PST, Joe Mason
joenotcharles: review-
Details | Formatted Diff | Diff
fix (4.22 KB, patch)
2013-02-14 14:35 PST, Joe Mason
yong.li.webkit: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
rebased fix (4.25 KB, patch)
2013-02-14 16:02 PST, Joe Mason
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Mason 2013-02-14 13:22:06 PST
The requireAuth parameter of NetworkJob::notifyAuthReceived is redundant as its value can be determined from "result" - if result is AuthResultRetry, requireAuth is false, otherwise it is true. For code cleanup it should be removed.
Comment 1 Joe Mason 2013-02-14 14:33:06 PST
Created attachment 188430 [details]
Comment 2 Joe Mason 2013-02-14 14:33:53 PST
Comment on attachment 188430 [details]

changelog has the wrong PR number. Not sure how that happened
Comment 3 Joe Mason 2013-02-14 14:35:12 PST
Created attachment 188431 [details]
Comment 4 WebKit Review Bot 2013-02-14 14:41:26 PST
Comment on attachment 188431 [details]

Rejecting attachment 188431 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 188431, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
ile Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/platform/network/blackberry/NetworkJob.cpp
Hunk #2 FAILED at 355.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/platform/network/blackberry/NetworkJob.cpp.rej
patching file Source/WebCore/platform/network/blackberry/NetworkJob.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Yong Li']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16542754
Comment 5 Joe Mason 2013-02-14 14:45:27 PST
Seems we forgot to upstream something.
Comment 6 Joe Mason 2013-02-14 14:47:53 PST
I didn't realize https://bugs.webkit.org/show_bug.cgi?id=109751 isn't reviewed and committed yet
Comment 7 Joe Mason 2013-02-14 16:02:18 PST
Created attachment 188442 [details]
rebased fix
Comment 8 Build Bot 2013-02-14 20:48:47 PST
Comment on attachment 188442 [details]
rebased fix

Attachment 188442 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://queues.webkit.org/results/16537922

New failing tests:
Comment 9 WebKit Review Bot 2013-02-15 07:27:21 PST
Comment on attachment 188442 [details]
rebased fix

Clearing flags on attachment: 188442

Committed r142996: <http://trac.webkit.org/changeset/142996>
Comment 10 WebKit Review Bot 2013-02-15 07:27:25 PST
All reviewed patches have been landed.  Closing bug.