Bug 109849 - AX: Split WebAccessibilityObjectWrapper so code can be shared with iOS
Summary: AX: Split WebAccessibilityObjectWrapper so code can be shared with iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: chris fleizach
URL:
Keywords:
Depends on: 109986
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-14 11:15 PST by chris fleizach
Modified: 2013-02-21 09:53 PST (History)
9 users (show)

See Also:

Attachments
patch (318.82 KB, patch)
2013-02-14 13:54 PST, chris fleizach 		ddkilzer: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
patch for landing (311.80 KB, patch)
2013-02-15 17:40 PST, chris fleizach 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2013-02-14 11:15:01 PST 
We need to split out some of the common routines in WebAccessibilityObject, like how we fetch titles and descriptions, into a shared location so iOS can share it
Comment 1 chris fleizach 2013-02-14 13:54:06 PST 
Created attachment 188419 [details]
patch
Comment 2 Build Bot 2013-02-15 12:16:14 PST 
Comment on attachment 188419 [details]
patch

Attachment 188419 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/16585249

New failing tests:
platform/mac/accessibility/aria-liveregions-removedelement.html
platform/mac/accessibility/aria-listbox-selectedchildren-change.html
platform/mac/accessibility/aria-liveregions-notifications-always-sent.html
accessibility/aria-invalid.html
accessibility/loading-iframe-sends-notification.html
accessibility/notification-listeners.html
platform/mac/accessibility/aria-liveregions-notifications.html
platform/mac/accessibility/aria-liveregions-changedtext.html
platform/mac/accessibility/selected-rows-table.html
platform/mac/accessibility/aria-liveregion-on-image.html
platform/mac/accessibility/textbox-role-reports-notifications.html
platform/mac/accessibility/combobox-activedescendant-notifications.html
platform/mac/accessibility/aria-liveregions-addedelement.html
platform/mac/accessibility/aria-liveregions-changedalt.html
platform/mac/accessibility/aria-expanded-notifications.html
platform/mac/accessibility/html-slider-indicator.html
Comment 3 David Kilzer (:ddkilzer) 2013-02-15 13:28:09 PST 
Comment on attachment 188419 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188419&action=review

r=me

> Source/WebCore/ChangeLog:19
> +        * accessibility/mac/WebAccessibilityObjectWrapper.h:
> +        * accessibility/mac/WebAccessibilityObjectWrapper.mm:

For shared code between iOS and Mac, we still need to come up with a name.  When we do, these files should move a subdirectory named that (like /apple/).
Comment 4 chris fleizach 2013-02-15 16:19:48 PST 
http://trac.webkit.org/changeset/143066
Comment 6 chris fleizach 2013-02-15 17:40:49 PST 
Created attachment 188675 [details]
patch for landing
Comment 7 WebKit Review Bot 2013-02-15 21:58:11 PST 
Comment on attachment 188675 [details]
patch for landing

Clearing flags on attachment: 188675

Committed r143098: <http://trac.webkit.org/changeset/143098>
Comment 8 chris fleizach 2013-02-21 09:53:35 PST 
http://trac.webkit.org/changeset/143230