We need to split out some of the common routines in WebAccessibilityObject, like how we fetch titles and descriptions, into a shared location so iOS can share it
Created attachment 188419 [details] patch
Comment on attachment 188419 [details] patch Attachment 188419 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/16585249 New failing tests: platform/mac/accessibility/aria-liveregions-removedelement.html platform/mac/accessibility/aria-listbox-selectedchildren-change.html platform/mac/accessibility/aria-liveregions-notifications-always-sent.html accessibility/aria-invalid.html accessibility/loading-iframe-sends-notification.html accessibility/notification-listeners.html platform/mac/accessibility/aria-liveregions-notifications.html platform/mac/accessibility/aria-liveregions-changedtext.html platform/mac/accessibility/selected-rows-table.html platform/mac/accessibility/aria-liveregion-on-image.html platform/mac/accessibility/textbox-role-reports-notifications.html platform/mac/accessibility/combobox-activedescendant-notifications.html platform/mac/accessibility/aria-liveregions-addedelement.html platform/mac/accessibility/aria-liveregions-changedalt.html platform/mac/accessibility/aria-expanded-notifications.html platform/mac/accessibility/html-slider-indicator.html
Comment on attachment 188419 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=188419&action=review r=me > Source/WebCore/ChangeLog:19 > + * accessibility/mac/WebAccessibilityObjectWrapper.h: > + * accessibility/mac/WebAccessibilityObjectWrapper.mm: For shared code between iOS and Mac, we still need to come up with a name. When we do, these files should move a subdirectory named that (like /apple/).
http://trac.webkit.org/changeset/143066
(In reply to comment #4) > http://trac.webkit.org/changeset/143066 Broke Apple Lion build (at least): http://build.webkit.org/builders/Apple%20Lion%20%28Leaks%29/builds/3849/steps/compile-webkit/logs/stdio
Created attachment 188675 [details] patch for landing
Comment on attachment 188675 [details] patch for landing Clearing flags on attachment: 188675 Committed r143098: <http://trac.webkit.org/changeset/143098>
http://trac.webkit.org/changeset/143230