Bug 109848 - [GTK][AC] Implement matrix transform animation with clutter ac backend
Summary: [GTK][AC] Implement matrix transform animation with clutter ac backend
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 105699
  Show dependency tree / graph
 
Reported: 2013-02-14 11:12 PST by ChangSeok Oh
Modified: 2013-02-19 12:11 PST (History)
3 users (show)

See Also:

Attachments
Patch (12.38 KB, patch)
2013-02-14 11:50 PST, ChangSeok Oh 		gustavo: commit-queue-
Details | Formatted Diff | Diff
Patch (12.52 KB, patch)
2013-02-19 10:54 PST, ChangSeok Oh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2013-02-14 11:12:58 PST 
This bug handles matrix transform animation with clutter ac backend.
Comment 1 ChangSeok Oh 2013-02-14 11:50:41 PST 
Created attachment 188394 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2013-02-19 06:39:21 PST 
Comment on attachment 188394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188394&action=review

> Source/WebCore/platform/graphics/clutter/PlatformClutterAnimation.cpp:459
> +    // FIXME: The matrix interpolation api, clutter_matrix_progress of Clutter 1.12 works unexpectedly.
> +    // So we overwrite it and handle the interpolation of two matrices with TransformationMatrix.

Would be good to link to a bug report here.
Comment 3 ChangSeok Oh 2013-02-19 10:54:41 PST 
Created attachment 189114 [details]
Patch
Comment 4 ChangSeok Oh 2013-02-19 10:56:46 PST 
Comment on attachment 188394 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188394&action=review

Thanks for the review!

>> Source/WebCore/platform/graphics/clutter/PlatformClutterAnimation.cpp:459
>> +    // So we overwrite it and handle the interpolation of two matrices with TransformationMatrix.
> 
> Would be good to link to a bug report here.

Reported here https://bugzilla.gnome.org/show_bug.cgi?id=694197
Comment 5 WebKit Review Bot 2013-02-19 12:11:53 PST 
Comment on attachment 189114 [details]
Patch

Clearing flags on attachment: 189114

Committed r143369: <http://trac.webkit.org/changeset/143369>
Comment 6 WebKit Review Bot 2013-02-19 12:11:57 PST 
All reviewed patches have been landed.  Closing bug.