Bug 109824 - [CoordGfx] Minor cleanup in CoordinatedGraphicsScene::paintToGraphicsContext
Summary: [CoordGfx] Minor cleanup in CoordinatedGraphicsScene::paintToGraphicsContext
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Balazs Kelemen
URL:
Keywords:
Depends on: 110596
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-14 06:22 PST by Balazs Kelemen
Modified: 2013-02-22 05:44 PST (History)
2 users (show)

See Also:


Attachments
Patch (3.23 KB, patch)
2013-02-14 06:25 PST, Balazs Kelemen
no flags Details | Formatted Diff | Diff
Patch (5.50 KB, patch)
2013-02-14 08:24 PST, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2013-02-14 06:22:47 PST
Those #ifdefs are quite ugly, also bad for IDE's. Let's use a typedef.
Comment 1 Balazs Kelemen 2013-02-14 06:25:46 PST
Created attachment 188335 [details]
Patch
Comment 2 Noam Rosenthal 2013-02-14 07:47:26 PST
Comment on attachment 188335 [details]
Patch

Can't we use the existing PaltformGraphicsContext typedef in GraphicsContext.h?
Comment 3 Balazs Kelemen 2013-02-14 08:24:42 PST
Created attachment 188359 [details]
Patch
Comment 4 Noam Rosenthal 2013-02-14 08:27:46 PST
Comment on attachment 188359 [details]
Patch

I'm ok with this; Please get a WK2 signoff.
Comment 5 Balazs Kelemen 2013-02-22 04:43:30 PST
Could you approve Kling, it's just a style nit :)