WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
109824
[CoordGfx] Minor cleanup in CoordinatedGraphicsScene::paintToGraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=109824
Summary
[CoordGfx] Minor cleanup in CoordinatedGraphicsScene::paintToGraphicsContext
Balazs Kelemen
Reported
2013-02-14 06:22:47 PST
Those #ifdefs are quite ugly, also bad for IDE's. Let's use a typedef.
Attachments
Patch
(3.23 KB, patch)
2013-02-14 06:25 PST
,
Balazs Kelemen
no flags
Details
Formatted Diff
Diff
Patch
(5.50 KB, patch)
2013-02-14 08:24 PST
,
Balazs Kelemen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Balazs Kelemen
Comment 1
2013-02-14 06:25:46 PST
Created
attachment 188335
[details]
Patch
Noam Rosenthal
Comment 2
2013-02-14 07:47:26 PST
Comment on
attachment 188335
[details]
Patch Can't we use the existing PaltformGraphicsContext typedef in GraphicsContext.h?
Balazs Kelemen
Comment 3
2013-02-14 08:24:42 PST
Created
attachment 188359
[details]
Patch
Noam Rosenthal
Comment 4
2013-02-14 08:27:46 PST
Comment on
attachment 188359
[details]
Patch I'm ok with this; Please get a WK2 signoff.
Balazs Kelemen
Comment 5
2013-02-22 04:43:30 PST
Could you approve Kling, it's just a style nit :)
Balazs Kelemen
Comment 6
2013-02-22 05:44:41 PST
Comment on
attachment 188359
[details]
Patch Landed in
http://trac.webkit.org/changeset/143714
. And
http://trac.webkit.org/changeset/143715
. And
http://trac.webkit.org/changeset/143717
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug