Bug 109813 - Web Inspector: always show memory size in Mb on the native memory graph
Summary: Web Inspector: always show memory size in Mb on the native memory graph
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-14 04:42 PST by Yury Semikhatsky
Modified: 2013-02-14 23:46 PST (History)
9 users (show)

See Also:


Attachments
Patch (1.67 KB, patch)
2013-02-14 04:43 PST, Yury Semikhatsky
no flags Details | Formatted Diff | Diff
Screenshot with the patch applied (121.60 KB, image/png)
2013-02-14 04:43 PST, Yury Semikhatsky
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2013-02-14 04:42:24 PST
The memory is displayed in bytes/Kb/Mb at the moment which makes it harder to compare counter values. Also such precision doesn't make much sense for the end users.
Comment 1 Yury Semikhatsky 2013-02-14 04:43:23 PST
Created attachment 188320 [details]
Patch
Comment 2 Yury Semikhatsky 2013-02-14 04:43:49 PST
Created attachment 188322 [details]
Screenshot with the patch applied
Comment 3 WebKit Review Bot 2013-02-14 09:53:37 PST
Comment on attachment 188320 [details]
Patch

Rejecting attachment 188320 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 188320, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
t/git/webkit-commit-queue/Source/WebKit/chromium/v8 --revision 13634 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
53>At revision 13634.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/16537689
Comment 4 WebKit Review Bot 2013-02-14 23:46:56 PST
Comment on attachment 188320 [details]
Patch

Clearing flags on attachment: 188320

Committed r142969: <http://trac.webkit.org/changeset/142969>
Comment 5 WebKit Review Bot 2013-02-14 23:46:59 PST
All reviewed patches have been landed.  Closing bug.