Bug 109786 - [V8] Remove GenerateEventListenerCallback() from CodeGeneratorV8.pm
Summary: [V8] Remove GenerateEventListenerCallback() from CodeGeneratorV8.pm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-13 23:02 PST by Kentaro Hara
Modified: 2013-02-14 16:19 PST (History)
3 users (show)

See Also:


Attachments
Patch (5.38 KB, patch)
2013-02-13 23:04 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-02-13 23:02:48 PST
Some code is duplicated between GenerateEventListenerCallback() and GenerateFunctionCallback(). By inlining GenerateEventListenerCallback() into GenerateFunctionCallback(), we can remove the duplication.
Comment 1 Kentaro Hara 2013-02-13 23:04:06 PST
Created attachment 188265 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-14 16:19:31 PST
Comment on attachment 188265 [details]
Patch

Clearing flags on attachment: 188265

Committed r142934: <http://trac.webkit.org/changeset/142934>
Comment 3 WebKit Review Bot 2013-02-14 16:19:34 PST
All reviewed patches have been landed.  Closing bug.