Bug 109768 – Fix indentation error in MediaPlayerPrivateGStreamer.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Soo-Hyun Choi]

Indentation used in MediaPlayerPrivateGStreamer.h doesn't seem to be matched with WebKit coding style (http://www.webkit.org/coding/coding-style.html).

[Soo-Hyun Choi]

Created attachment 188220 [details]
Patch

[WebKit Review Bot]

Attachment 188220 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h']" exit_code: 1
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:110:  The parameter name "state" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kentaro Hara]

Comment on attachment 188220 [details]
Patch

Please fix the style error before landing.

[Soo-Hyun Choi]

(In reply to comment #3)
> (From update of attachment 188220 [details])
> Please fix the style error before landing.

Sure - I will just remove the parameter name "state" in this patch.

[Soo-Hyun Choi]

Created attachment 188225 [details]
Patch

[WebKit Review Bot]

Comment on attachment 188225 [details]
Patch

Rejecting attachment 188225 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 188225, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
commit-queue/Source/WebKit/chromium/third_party/v8-i18n --revision 164 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
54>At revision 164.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/16538378

[Soo-Hyun Choi]

Created attachment 188249 [details]
Patch

[Soo-Hyun Choi]

(In reply to comment #6)
> (From update of attachment 188225 [details])
> Rejecting attachment 188225 [details] from commit-queue.
> 
> Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 188225, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue
> 
> Last 500 characters of output:
> commit-queue/Source/WebKit/chromium/third_party/v8-i18n --revision 164 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> 54>At revision 164.
> 
> ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> 
> ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
> Updating webkit projects from gyp files...
> 
> Full output: http://queues.webkit.org/results/16538378

This error was occurred due to the unchanged statememnt of "No New Test (OOPS!)", which I have fixed and re-uploaded.

cq again?

[WebKit Review Bot]

Comment on attachment 188249 [details]
Patch

Clearing flags on attachment: 188249

Committed r142845: <http://trac.webkit.org/changeset/142845>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.