Bug 109763 - Make WebKit2 Derived Sources work with SDK identifiers too
Summary: Make WebKit2 Derived Sources work with SDK identifiers too
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P3 Minor
Assignee: David Farler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-13 16:00 PST by David Farler
Modified: 2013-02-13 17:32 PST (History)
3 users (show)

See Also:

Attachments
Patch (2.08 KB, patch)
2013-02-13 16:29 PST, David Farler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Farler 2013-02-13 16:00:52 PST 
Similar to https://bugs.webkit.org/show_bug.cgi?id=109324,

Source/WebCore/DerivedSources.make invokes CC with -isysroot $(SDKROOT), which won't work if you use an SDK identifier instead of an absolute path in Xcode. Where necessary, we should use pass SDKROOT=${SDKROOT} to make as we did in WebCore. This will let us use SDK identifiers when building with the makefiles.
Comment 1 David Farler 2013-02-13 16:06:09 PST 
Source/WebKit2 I should say.
Comment 2 David Farler 2013-02-13 16:29:17 PST 
Created attachment 188217 [details]
Patch
Comment 3 David Kilzer (:ddkilzer) 2013-02-13 17:04:52 PST 
Comment on attachment 188217 [details]
Patch

r=me
Comment 4 WebKit Review Bot 2013-02-13 17:32:41 PST 
Comment on attachment 188217 [details]
Patch

Clearing flags on attachment: 188217

Committed r142830: <http://trac.webkit.org/changeset/142830>
Comment 5 WebKit Review Bot 2013-02-13 17:32:44 PST 
All reviewed patches have been landed.  Closing bug.