Bug 109762 - IndexedDB: Add a few more histogram calls
Summary: IndexedDB: Add a few more histogram calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Grogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-13 16:00 PST by David Grogan
Modified: 2013-02-14 10:19 PST (History)
4 users (show)

See Also:


Attachments
Patch (2.13 KB, patch)
2013-02-13 16:00 PST, David Grogan
no flags Details | Formatted Diff | Diff
Patch (2.13 KB, patch)
2013-02-13 16:13 PST, David Grogan
no flags Details | Formatted Diff | Diff
Patch (2.13 KB, patch)
2013-02-13 17:42 PST, David Grogan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Grogan 2013-02-13 16:00:03 PST
IndexedDB: Add a few more uma logging calls
Comment 1 David Grogan 2013-02-13 16:00:41 PST
Created attachment 188208 [details]
Patch
Comment 2 David Grogan 2013-02-13 16:01:32 PST
Josh, could you prereview this?
Comment 3 WebKit Review Bot 2013-02-13 16:12:06 PST
Attachment 188208 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp']" exit_code: 1
Source/WebCore/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 David Grogan 2013-02-13 16:13:15 PST
Created attachment 188209 [details]
Patch
Comment 5 Joshua Bell 2013-02-13 16:58:43 PST
Comment on attachment 188209 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188209&action=review

lgtm

> Source/WebCore/ChangeLog:3
> +        IndexedDB: Add a few more uma logging calls

Nit: UMA is Google/Chromium-specific terminology, Histogram is the generic WebKit API being used, so I'd refer to it that way.

> Source/WebCore/ChangeLog:8
> +        A few places where commits could fail weren't being logged.

Whoah, how'd we miss these? :(
Comment 6 David Grogan 2013-02-13 17:42:54 PST
Created attachment 188235 [details]
Patch
Comment 7 David Grogan 2013-02-13 17:43:46 PST
Tony, could you review this?
Comment 8 WebKit Review Bot 2013-02-14 10:19:34 PST
Comment on attachment 188235 [details]
Patch

Clearing flags on attachment: 188235

Committed r142890: <http://trac.webkit.org/changeset/142890>
Comment 9 WebKit Review Bot 2013-02-14 10:19:37 PST
All reviewed patches have been landed.  Closing bug.