WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED WONTFIX
109761
Move all .props files from WebKitLibraries folder into WebKit Source folder
https://bugs.webkit.org/show_bug.cgi?id=109761
Summary
Move all .props files from WebKitLibraries folder into WebKit Source folder
Roger Fong
Reported
2013-02-13 15:55:22 PST
VS property sheets should be dissociated from WebKitLibraries.
Attachments
patch
(93.46 KB, patch)
2013-02-13 16:00 PST
,
Roger Fong
bfulgham
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Roger Fong
Comment 1
2013-02-13 16:00:01 PST
***
Bug 109311
has been marked as a duplicate of this bug. ***
Roger Fong
Comment 2
2013-02-13 16:00:39 PST
Created
attachment 188207
[details]
patch
Brent Fulgham
Comment 3
2013-02-13 23:21:48 PST
Comment on
attachment 188207
[details]
patch While I don't really care where these live, is there any particular reason we want to move them? I don't know the history of why they were put in the WebKitLibraries folder (maybe sfalken knows?). Anyway, the patch looks fine, and if the other Apple devs are okay with the change it is fine with me.
Roger Fong
Comment 4
2013-02-14 11:54:29 PST
(In reply to
comment #3
)
> (From update of
attachment 188207
[details]
) > While I don't really care where these live, is there any particular reason we want to move them? I don't know the history of why they were put in the WebKitLibraries folder (maybe sfalken knows?). > > Anyway, the patch looks fine, and if the other Apple devs are okay with the change it is fine with me.
There tend to be issues when you try to update WebKitLibraries with AAS stuff when WEBKITLIBRARIES points to that folder. It's mostly bot related. I'll shoot Steve an email to see what he thinks.
Roger Fong
Comment 5
2013-03-19 12:24:05 PDT
Files have been moved but there is there are some WebCoreGenerated scripts that need to be modified as well.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug