Bug 109761 - Move all .props files from WebKitLibraries folder into WebKit Source folder
Summary: Move all .props files from WebKitLibraries folder into WebKit Source folder
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 109311 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-02-13 15:55 PST by Roger Fong
Modified: 2013-06-03 14:59 PDT (History)
4 users (show)

See Also:

Attachments
patch (93.46 KB, patch)
2013-02-13 16:00 PST, Roger Fong 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-02-13 15:55:22 PST 
VS property sheets should be dissociated from WebKitLibraries.
Comment 1 Roger Fong 2013-02-13 16:00:01 PST 
*** Bug 109311 has been marked as a duplicate of this bug. ***
Comment 2 Roger Fong 2013-02-13 16:00:39 PST 
Created attachment 188207 [details]
patch
Comment 3 Brent Fulgham 2013-02-13 23:21:48 PST 
Comment on attachment 188207 [details]
patch

While I don't really care where these live, is there any particular reason we want to move them?  I don't know the history of why they were put in the WebKitLibraries folder (maybe sfalken knows?).

Anyway, the patch looks fine, and if the other Apple devs are okay with the change it is fine with me.
Comment 4 Roger Fong 2013-02-14 11:54:29 PST 
(In reply to comment #3)
> (From update of attachment 188207 [details])
> While I don't really care where these live, is there any particular reason we want to move them?  I don't know the history of why they were put in the WebKitLibraries folder (maybe sfalken knows?).
> 
> Anyway, the patch looks fine, and if the other Apple devs are okay with the change it is fine with me.

There tend to be issues when you try to update WebKitLibraries with AAS stuff when WEBKITLIBRARIES points to that folder. 
It's mostly bot related. I'll shoot Steve an email to see what he thinks.
Comment 5 Roger Fong 2013-03-19 12:24:05 PDT 
Files have been moved but there is there are some WebCoreGenerated scripts that need to be modified as well.