Bug 109760 - HTMLTokenScanner should be (mostly!) thread-safe
Summary: HTMLTokenScanner should be (mostly!) thread-safe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency tree / graph
 
Reported: 2013-02-13 15:45 PST by Adam Barth
Modified: 2013-02-13 19:33 PST (History)
3 users (show)

See Also:

Attachments
Patch (9.30 KB, patch)
2013-02-13 15:47 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (8.81 KB, patch)
2013-02-13 18:22 PST, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-02-13 15:45:36 PST 
HTMLTokenScanner should be (mostly!) thread-safe
Comment 1 Adam Barth 2013-02-13 15:47:50 PST 
Created attachment 188201 [details]
Patch
Comment 2 Adam Barth 2013-02-13 15:55:51 PST 
This patch will need to be re-based slightly since one of the early patches changed some of these names.
Comment 3 Eric Seidel (no email) 2013-02-13 16:14:32 PST 
Comment on attachment 188201 [details]
Patch

OK.
Comment 4 WebKit Review Bot 2013-02-13 16:40:41 PST 
Comment on attachment 188201 [details]
Patch

Rejecting attachment 188201 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 188201, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
eeded at 218 with fuzz 2 (offset -131 lines).
10 out of 11 hunks FAILED -- saving rejects to file Source/WebCore/html/parser/HTMLPreloadScanner.cpp.rej
patching file Source/WebCore/html/parser/HTMLPreloadScanner.h
Hunk #2 FAILED at 48.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/html/parser/HTMLPreloadScanner.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16530379
Comment 5 Adam Barth 2013-02-13 18:22:27 PST 
Created attachment 188246 [details]
Patch for landing
Comment 6 WebKit Review Bot 2013-02-13 19:33:38 PST 
Comment on attachment 188246 [details]
Patch for landing

Clearing flags on attachment: 188246

Committed r142843: <http://trac.webkit.org/changeset/142843>
Comment 7 WebKit Review Bot 2013-02-13 19:33:41 PST 
All reviewed patches have been landed.  Closing bug.