Bug 109757 – Merge MainResourceLoader::willSendRequest into DocumentLoader

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Nate Chapin]

* Move willSendRequest() to DocumentLoader, except calling checkNavigationPolicy for redirects.
* Move isPostOrRedirectAfterPost(), which is only called from willSendRequest()
* Get rid of MainResourceLoader::m_substituteData, which doesn't appear to need to be separate from DocumentLoader::m_substituteData

[Nate Chapin]

Created attachment 188204 [details]
patch

[WebKit Review Bot]

Comment on attachment 188204 [details]
patch

Attachment 188204 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16536367

New failing tests:
http/tests/security/referrer-policy-always.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-blocked.html
platform/chromium/http/tests/security/mixedContent/insecure-iframe-in-main-frame-blocked.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-get-blocked.html
http/tests/security/contentSecurityPolicy/1.1/form-action-src-redirect-blocked.html

[Nate Chapin]

Created attachment 188418 [details]
Move checkNavigationPolicy to DocumentLoader too

[Build Bot]

Comment on attachment 188418 [details]
Move checkNavigationPolicy to DocumentLoader too

Attachment 188418 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/16587651

[Nate Chapin]

Created attachment 192759 [details]
Merged to trunk

[Build Bot]

Comment on attachment 192759 [details]
Merged to trunk

Attachment 192759 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17036740

[Nate Chapin]

Created attachment 193005 [details]
Merged to trunk again

[Build Bot]

Comment on attachment 193005 [details]
Merged to trunk again

Attachment 193005 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17207147

[Adam Barth]

Comment on attachment 193005 [details]
Merged to trunk again

Is this patch still current?  Would you like me to look at it now, or should we resolve the win-ews redness first?

[Nate Chapin]

(In reply to comment #9)
> (From update of attachment 193005 [details])
> Is this patch still current?  Would you like me to look at it now, or should we resolve the win-ews redness first?

It's current, but I haven't figured out why win-ews is red because an undefined HTMLFormElement while the other platforms compile.

[Nate Chapin]

Created attachment 193355 [details]
Try again to fix win-ews

[Antti Koivisto]

Comment on attachment 193355 [details]
Try again to fix win-ews

View in context: https://bugs.webkit.org/attachment.cgi?id=193355&action=review

r=me

> Source/WebCore/ChangeLog:8
> +        Merge MainResourceLoader::willSendRequest into DocumentLoader 
> +        https://bugs.webkit.org/show_bug.cgi?id=109757
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        No new tests, refactor only.

A few words of motivation would be nice.

[Nate Chapin]

Created attachment 193372 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 193372 [details]
Patch for landing

Clearing flags on attachment: 193372

Committed r145973: <http://trac.webkit.org/changeset/145973>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.