Bug 109756 - Remove Element::getAttributeItem() overload that returned a mutable Attribute*.
Summary: Remove Element::getAttributeItem() overload that returned a mutable Attribute*.
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Blocks: 109505
  Show dependency treegraph
Reported: 2013-02-13 15:16 PST by Andreas Kling
Modified: 2013-02-13 17:14 PST (History)
10 users (show)

See Also:

Patch (5.10 KB, patch)
2013-02-13 15:18 PST, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-02-13 15:16:19 PST
It's a bit goofy to have an Element::getAttributeItem() that converts m_elementData to UniqueElementData.
This happens unintentionally in a few places where callers simply want to read an attribute value but are calling through an Element*.
Comment 1 Andreas Kling 2013-02-13 15:18:24 PST
Created attachment 188195 [details]
Comment 2 Antti Koivisto 2013-02-13 16:24:21 PST
Comment on attachment 188195 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=188195&action=review

> Source/WebCore/dom/Element.h:287
>      const Attribute* getAttributeItem(const QualifiedName&) const;

Some day these should get WebKit style names.
Comment 3 Andreas Kling 2013-02-13 17:14:10 PST
Committed r142827: <http://trac.webkit.org/changeset/142827>