Factor HTMLTokenScanner out of HTMLPreloadScanner
Created attachment 188193 [details] Patch
Comment on attachment 188193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188193&action=review I think HTMLTokenScanner is decepitvely unrelated to preloading, but this is a good factoring. :) the preload scanner clearly needed a bath. > Source/WebCore/html/parser/HTMLPreloadScanner.cpp:350 > + // Note: m_token is only used from this function and for the main thread. > + // All other functions are passed a token. This is unrelated now? > Source/WebCore/html/parser/HTMLPreloadScanner.h:44 > + explicit HTMLTokenScanner(const KURL& documentURL); It feels like a TokenPreloadScanner, since it still has something to do with preloading.
Comment on attachment 188193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188193&action=review >> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:350 >> + // All other functions are passed a token. > > This is unrelated now? Yeah. I'll remove the comment. >> Source/WebCore/html/parser/HTMLPreloadScanner.h:44 >> + explicit HTMLTokenScanner(const KURL& documentURL); > > It feels like a TokenPreloadScanner, since it still has something to do with preloading. Yes!
Created attachment 188205 [details] Patch for landing
Comment on attachment 188205 [details] Patch for landing Clearing flags on attachment: 188205 Committed r142822: <http://trac.webkit.org/changeset/142822>
All reviewed patches have been landed. Closing bug.