Bug 109754 - Factor TokenPreloadScanner out of HTMLPreloadScanner
Summary: Factor TokenPreloadScanner out of HTMLPreloadScanner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 106127
  Show dependency treegraph
 
Reported: 2013-02-13 15:06 PST by Adam Barth
Modified: 2013-02-13 16:58 PST (History)
4 users (show)

See Also:


Attachments
Patch (9.26 KB, patch)
2013-02-13 15:08 PST, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (8.81 KB, patch)
2013-02-13 15:53 PST, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2013-02-13 15:06:07 PST
Factor HTMLTokenScanner out of HTMLPreloadScanner
Comment 1 Adam Barth 2013-02-13 15:08:44 PST
Created attachment 188193 [details]
Patch
Comment 2 Eric Seidel (no email) 2013-02-13 15:29:53 PST
Comment on attachment 188193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188193&action=review

I think HTMLTokenScanner is decepitvely unrelated to preloading, but this is a good factoring. :)  the preload scanner clearly needed a bath.

> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:350
> +    // Note: m_token is only used from this function and for the main thread.
> +    // All other functions are passed a token.

This is unrelated now?

> Source/WebCore/html/parser/HTMLPreloadScanner.h:44
> +    explicit HTMLTokenScanner(const KURL& documentURL);

It feels like a TokenPreloadScanner, since it still has something to do with preloading.
Comment 3 Adam Barth 2013-02-13 15:44:10 PST
Comment on attachment 188193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188193&action=review

>> Source/WebCore/html/parser/HTMLPreloadScanner.cpp:350
>> +    // All other functions are passed a token.
> 
> This is unrelated now?

Yeah.  I'll remove the comment.

>> Source/WebCore/html/parser/HTMLPreloadScanner.h:44
>> +    explicit HTMLTokenScanner(const KURL& documentURL);
> 
> It feels like a TokenPreloadScanner, since it still has something to do with preloading.

Yes!
Comment 4 Adam Barth 2013-02-13 15:53:40 PST
Created attachment 188205 [details]
Patch for landing
Comment 5 WebKit Review Bot 2013-02-13 16:58:26 PST
Comment on attachment 188205 [details]
Patch for landing

Clearing flags on attachment: 188205

Committed r142822: <http://trac.webkit.org/changeset/142822>
Comment 6 WebKit Review Bot 2013-02-13 16:58:29 PST
All reviewed patches have been landed.  Closing bug.