Bug 109748 - Consolidate main functions in WebKit2 now that they are all identical
Summary: Consolidate main functions in WebKit2 now that they are all identical
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-13 14:07 PST by Sam Weinig
Modified: 2013-02-13 14:47 PST (History)
1 user (show)

See Also:


Attachments
Patch (135.58 KB, patch)
2013-02-13 14:14 PST, Sam Weinig
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2013-02-13 14:07:21 PST
Consolidate main functions in WebKit2 now that they are all identical
Comment 1 Sam Weinig 2013-02-13 14:14:20 PST
Created attachment 188181 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-13 14:20:07 PST
Attachment 188181 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Configurations/BaseLegacyProcess.xcconfig', u'Source/WebKit2/Configurations/BaseXPCService.xcconfig', u'Source/WebKit2/Configurations/NetworkProcess.xcconfig', u'Source/WebKit2/Configurations/OfflineStorageProcess.xcconfig', u'Source/WebKit2/Configurations/PluginProcess.xcconfig', u'Source/WebKit2/Configurations/SharedWorkerProcess.xcconfig', u'Source/WebKit2/Configurations/WebContentProcess.xcconfig', u'Source/WebKit2/Configurations/WebProcess.xcconfig', u'Source/WebKit2/NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist', u'Source/WebKit2/NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMain.mm', u'Source/WebKit2/NetworkProcess/EntryPoint/mac/LegacyProcess/NetworkProcessMainBootstrapper.cpp', u'Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/NetworkServiceMain.Development.mm', u'Source/WebKit2/NetworkProcess/EntryPoint/mac/XPCService/NetworkService/NetworkServiceMain.mm', u'Source/WebKit2/OfflineStorageProcess/EntryPoint/mac/LegacyProcess/Info.plist', u'Source/WebKit2/OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMain.mm', u'Source/WebKit2/OfflineStorageProcess/EntryPoint/mac/LegacyProcess/OfflineStorageProcessMainBootstrapper.cpp', u'Source/WebKit2/OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService.Development/OfflineStorageServiceMain.Development.mm', u'Source/WebKit2/OfflineStorageProcess/EntryPoint/mac/XPCService/OfflineStorageService/OfflineStorageServiceMain.mm', u'Source/WebKit2/PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist', u'Source/WebKit2/PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm', u'Source/WebKit2/PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMainBootstrapper.cpp', u'Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.64/PluginService.64.Main.mm', u'Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/PluginService.Development.Main.mm', u'Source/WebKit2/Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h', u'Source/WebKit2/Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm', u'Source/WebKit2/Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.h', u'Source/WebKit2/Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMain.mm', u'Source/WebKit2/Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessMainBootstrapper.h', u'Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.Development.h', u'Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceBootstrapper.h', u'Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm', u'Source/WebKit2/Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm', u'Source/WebKit2/SharedWorkerProcess/EntryPoint/mac/LegacyProcess/Info.plist', u'Source/WebKit2/SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMain.mm', u'Source/WebKit2/SharedWorkerProcess/EntryPoint/mac/LegacyProcess/SharedWorkerProcessMainBootstrapper.cpp', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/EntryPoint/mac/LegacyProcess/Info.plist', u'Source/WebKit2/WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm', u'Source/WebKit2/WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMainBootstrapper.cpp', u'Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/WebContentServiceMain.Development.mm', u'Source/WebKit2/WebProcess/EntryPoint/mac/XPCService/WebContentService/WebContentServiceMain.mm']" exit_code: 1
Source/WebKit2/Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:50:  The parameter name "identifier" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2013-02-13 14:47:35 PST
Committed r142806: <http://trac.webkit.org/changeset/142806>