Bug 109742 – CSSPreloadScanner should not depend on HTMLToken

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adam Barth]

CSSPreloadScanner should not depend on HTMLToken

[Adam Barth]

Created attachment 188162 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 188162 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188162&action=review

> Source/WebCore/html/parser/CSSPreloadScanner.cpp:61
> +void CSSPreloadScanner::scan(const LChar* begin, const LChar* end, Vector<OwnPtr<PreloadRequest> >& requests)

This is just a template. :)

> Source/WebCore/html/parser/CSSPreloadScanner.h:44
> +    void scan(const LChar* begin, const LChar* end, Vector<OwnPtr<PreloadRequest> >&);

This isn't currently used, or?

[Adam Barth]

(In reply to comment #2)
> (From update of attachment 188162 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=188162&action=review
> 
> > Source/WebCore/html/parser/CSSPreloadScanner.cpp:61
> > +void CSSPreloadScanner::scan(const LChar* begin, const LChar* end, Vector<OwnPtr<PreloadRequest> >& requests)
> 
> This is just a template. :)

Yes.  ;)

> > Source/WebCore/html/parser/CSSPreloadScanner.h:44
> > +    void scan(const LChar* begin, const LChar* end, Vector<OwnPtr<PreloadRequest> >&);
> 
> This isn't currently used, or?

Current unused.  I can add it later when we need it if you like.

[WebKit Review Bot]

Comment on attachment 188162 [details]
Patch

Clearing flags on attachment: 188162

Committed r142803: <http://trac.webkit.org/changeset/142803>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.