Bug 109735 - [chromium] No triggering autofill on unfocus
Summary: [chromium] No triggering autofill on unfocus
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-13 12:41 PST by David Trainor
Modified: 2013-02-14 15:43 PST (History)
8 users (show)

See Also:


Attachments
Patch (2.92 KB, patch)
2013-02-13 12:45 PST, David Trainor
no flags Details | Formatted Diff | Diff
Patch (6.97 KB, patch)
2013-02-13 15:35 PST, David Trainor
no flags Details | Formatted Diff | Diff
Patch (6.98 KB, patch)
2013-02-13 17:32 PST, David Trainor
no flags Details | Formatted Diff | Diff
Patch (6.75 KB, patch)
2013-02-14 13:47 PST, David Trainor
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Trainor 2013-02-13 12:41:46 PST
No triggering autofill on unfocus
Comment 1 David Trainor 2013-02-13 12:45:00 PST
Created attachment 188153 [details]
Patch
Comment 2 David Trainor 2013-02-13 12:56:12 PST
To fix showing the autofill popup when trying to defocus a field and therefore committing the text composition.

ptal!
Comment 3 WebKit Review Bot 2013-02-13 13:15:12 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 WebKit Review Bot 2013-02-13 13:15:29 PST
Attachment 188153 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Source/WebKit/chromium/public/WebAutofillClient.h', u'Source/WebKit/chromium/src/WebViewImpl.cpp']" exit_code: 1
Source/WebKit/chromium/src/WebViewImpl.cpp:2147:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebKit/chromium/src/WebViewImpl.cpp:2152:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 James Robinson 2013-02-13 13:16:52 PST
Comment on attachment 188153 [details]
Patch

Where's the test?
Comment 6 David Trainor 2013-02-13 15:35:53 PST
Created attachment 188198 [details]
Patch
Comment 7 WebKit Review Bot 2013-02-13 16:46:54 PST
Comment on attachment 188198 [details]
Patch

Attachment 188198 [details] did not pass cr-linux-debug-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16536348
Comment 8 WebKit Review Bot 2013-02-13 16:51:34 PST
Comment on attachment 188198 [details]
Patch

Attachment 188198 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/16581023
Comment 9 David Trainor 2013-02-13 17:32:09 PST
Created attachment 188234 [details]
Patch
Comment 10 David Trainor 2013-02-14 09:20:50 PST
Okay tests added and style checks fixed.
Comment 11 James Robinson 2013-02-14 10:44:55 PST
Happy to review the API bits once someone familiar with autofill looks at this.
Comment 12 David Trainor 2013-02-14 10:47:12 PST
isherman@ took a look at the corresponding Chromium change that implements these methods.  Ilya, do you think you could take a look?  If you're not the right person to ask do you know who should review this?  Thanks!
Comment 13 Ilya Sherman 2013-02-14 12:03:23 PST
Comment on attachment 188234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188234&action=review

Unofficial r+ for Autofill

> Source/WebKit/chromium/src/WebViewImpl.cpp:-2144
> -

nit: Unrelated change?
Comment 14 James Robinson 2013-02-14 13:12:01 PST
Comment on attachment 188234 [details]
Patch

R=me. Please remove the spurious whitespace change before landing
Comment 15 David Trainor 2013-02-14 13:47:09 PST
Created attachment 188417 [details]
Patch
Comment 16 David Trainor 2013-02-14 13:53:07 PST
Removed whitespace change.
Comment 17 David Trainor 2013-02-14 14:53:27 PST
James sorry can I get one more review?  Removed whitespace but needs that review before I can land the patch :(.
Comment 18 WebKit Review Bot 2013-02-14 14:59:10 PST
Comment on attachment 188417 [details]
Patch

Rejecting attachment 188417 [details] from review queue.

isherman@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 19 James Robinson 2013-02-14 15:04:12 PST
Comment on attachment 188417 [details]
Patch

Gonna toggle cq bit to make sure it gets picked up
Comment 20 WebKit Review Bot 2013-02-14 15:43:45 PST
Comment on attachment 188417 [details]
Patch

Clearing flags on attachment: 188417

Committed r142927: <http://trac.webkit.org/changeset/142927>
Comment 21 WebKit Review Bot 2013-02-14 15:43:50 PST
All reviewed patches have been landed.  Closing bug.