No triggering autofill on unfocus
Created attachment 188153 [details] Patch
To fix showing the autofill popup when trying to defocus a field and therefore committing the text composition. ptal!
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Attachment 188153 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Source/WebKit/chromium/public/WebAutofillClient.h', u'Source/WebKit/chromium/src/WebViewImpl.cpp']" exit_code: 1 Source/WebKit/chromium/src/WebViewImpl.cpp:2147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebKit/chromium/src/WebViewImpl.cpp:2152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 188153 [details] Patch Where's the test?
Created attachment 188198 [details] Patch
Comment on attachment 188198 [details] Patch Attachment 188198 [details] did not pass cr-linux-debug-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16536348
Comment on attachment 188198 [details] Patch Attachment 188198 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/16581023
Created attachment 188234 [details] Patch
Okay tests added and style checks fixed.
Happy to review the API bits once someone familiar with autofill looks at this.
isherman@ took a look at the corresponding Chromium change that implements these methods. Ilya, do you think you could take a look? If you're not the right person to ask do you know who should review this? Thanks!
Comment on attachment 188234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=188234&action=review Unofficial r+ for Autofill > Source/WebKit/chromium/src/WebViewImpl.cpp:-2144 > - nit: Unrelated change?
Comment on attachment 188234 [details] Patch R=me. Please remove the spurious whitespace change before landing
Created attachment 188417 [details] Patch
Removed whitespace change.
James sorry can I get one more review? Removed whitespace but needs that review before I can land the patch :(.
Comment on attachment 188417 [details] Patch Rejecting attachment 188417 [details] from review queue. isherman@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
Comment on attachment 188417 [details] Patch Gonna toggle cq bit to make sure it gets picked up
Comment on attachment 188417 [details] Patch Clearing flags on attachment: 188417 Committed r142927: <http://trac.webkit.org/changeset/142927>
All reviewed patches have been landed. Closing bug.