Bug 109724 - Remove unnecessary indirection to non-local variable access operations
Summary: Remove unnecessary indirection to non-local variable access operations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-13 11:52 PST by Oliver Hunt
Modified: 2013-02-13 23:20 PST (History)
3 users (show)

See Also:


Attachments
Patch (44.16 KB, patch)
2013-02-13 12:03 PST, Oliver Hunt
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2013-02-13 11:52:05 PST
Remove unnecessary indirection to non-local variable access operations
Comment 1 Oliver Hunt 2013-02-13 12:03:15 PST
Created attachment 188139 [details]
Patch
Comment 2 Oliver Hunt 2013-02-13 12:09:46 PST
Committed r142769: <http://trac.webkit.org/changeset/142769>
Comment 4 Julien Brianceau 2013-02-13 12:52:27 PST
This breaks our SH4 build slave too:
http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/20014

I took a look very quickly and I wonder if some parts of this patch should be conditionnal to DFG_JIT.
Comment 5 Roger Fong 2013-02-13 14:59:27 PST
(In reply to comment #3)
> Hello, this broke the Windows build:
> http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/44150/steps/compile-webkit/logs/stdio

Still broken but for a different reason:

http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/44173/steps/compile-webkit/logs/stdio

profile was placed in the DFG_JIT enable so it's no longer declared. I could move that line into the ifdef but I'd rather not risk touching this stuff.
Comment 6 Roger Fong 2013-02-13 16:48:25 PST
Can I roll this out? Or is someone working on a fix?
Comment 7 Oliver Hunt 2013-02-13 16:58:37 PST
(In reply to comment #6)
> Can I roll this out? Or is someone working on a fix?

I landed a fix
Comment 8 Roger Fong 2013-02-13 17:03:21 PST
Ah yup, Windows is broken on something else now.
Thanks for the fix!
Comment 9 Julien Brianceau 2013-02-13 23:20:39 PST
(In reply to comment #7)
> (In reply to comment #6)
> > Can I roll this out? Or is someone working on a fix?
> 
> I landed a fix

Thanks for the fix!