RESOLVED FIXED 109724
Remove unnecessary indirection to non-local variable access operations 
https://bugs.webkit.org/show_bug.cgi?id=109724
Summary Remove unnecessary indirection to non-local variable access operations
Oliver Hunt
Reported 2013-02-13 11:52:05 PST
Remove unnecessary indirection to non-local variable access operations
Attachments
Patch (44.16 KB, patch)
2013-02-13 12:03 PST, Oliver Hunt 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-02-13 12:03:15 PST
Created attachment 188139 [details] Patch
Oliver Hunt
Comment 2 2013-02-13 12:09:46 PST
Committed r142769: <http://trac.webkit.org/changeset/142769>
Julien Brianceau
Comment 4 2013-02-13 12:52:27 PST
This breaks our SH4 build slave too: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/20014 I took a look very quickly and I wonder if some parts of this patch should be conditionnal to DFG_JIT.
Roger Fong
Comment 5 2013-02-13 14:59:27 PST
(In reply to comment #3) > Hello, this broke the Windows build: > http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/44150/steps/compile-webkit/logs/stdio Still broken but for a different reason: http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/44173/steps/compile-webkit/logs/stdio profile was placed in the DFG_JIT enable so it's no longer declared. I could move that line into the ifdef but I'd rather not risk touching this stuff.
Roger Fong
Comment 6 2013-02-13 16:48:25 PST
Can I roll this out? Or is someone working on a fix?
Oliver Hunt
Comment 7 2013-02-13 16:58:37 PST
(In reply to comment #6) > Can I roll this out? Or is someone working on a fix? I landed a fix
Roger Fong
Comment 8 2013-02-13 17:03:21 PST
Ah yup, Windows is broken on something else now. Thanks for the fix!
Julien Brianceau
Comment 9 2013-02-13 23:20:39 PST
(In reply to comment #7) > (In reply to comment #6) > > Can I roll this out? Or is someone working on a fix? > > I landed a fix Thanks for the fix!
Note You need to log in before you can comment on or make changes to this bug.