Bug 109706 - [chromium] move mock notification presenter to TestRunner library
Summary: [chromium] move mock notification presenter to TestRunner library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks: 91308
  Show dependency tree / graph
 
Reported: 2013-02-13 09:11 PST by jochen
Modified: 2013-02-14 00:09 PST (History)
7 users (show)

See Also:

Attachments
Patch (36.32 KB, patch)
2013-02-13 09:13 PST, jochen 		no flags Details | Formatted Diff | Diff
Patch (38.36 KB, patch)
2013-02-13 10:20 PST, jochen 		no flags Details | Formatted Diff | Diff
Patch for landing (38.38 KB, patch)
2013-02-13 11:41 PST, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2013-02-13 09:11:48 PST 
[chromium] move mock notification presenter to TestRunner library
Comment 1 jochen 2013-02-13 09:13:37 PST 
Created attachment 188095 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-13 09:17:11 PST 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Peter Beverloo (cr-android ews) 2013-02-13 09:23:58 PST 
Comment on attachment 188095 [details]
Patch

Attachment 188095 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/16487964
Comment 4 jochen 2013-02-13 10:20:48 PST 
Created attachment 188115 [details]
Patch
Comment 5 Adam Barth 2013-02-13 11:33:03 PST 
Comment on attachment 188115 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188115&action=review

> Tools/DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h:44
> +// A class that implements WebNotificationPresenter for DRT.

DRT <--- I'd probably change this comment slightly.
Comment 6 jochen 2013-02-13 11:41:02 PST 
Created attachment 188132 [details]
Patch for landing
Comment 7 WebKit Review Bot 2013-02-14 00:09:20 PST 
Comment on attachment 188132 [details]
Patch for landing

Clearing flags on attachment: 188132

Committed r142857: <http://trac.webkit.org/changeset/142857>
Comment 8 WebKit Review Bot 2013-02-14 00:09:25 PST 
All reviewed patches have been landed.  Closing bug.