Bug 109697 - Web Inspector: Color picker should not be available in Computed Styles pane
Summary: Web Inspector: Color picker should not be available in Computed Styles pane
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vladislav Kaznacheev
URL:
Keywords:
Depends on: 109920
Blocks:
  Show dependency tree / graph
 
Reported: 2013-02-13 08:02 PST by Vladislav Kaznacheev
Modified: 2013-02-18 06:03 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.18 KB, patch)
2013-02-13 08:38 PST, Vladislav Kaznacheev 		no flags Details | Formatted Diff | Diff
Patch (27.91 KB, patch)
2013-02-18 02:07 PST, Vladislav Kaznacheev 		no flags Details | Formatted Diff | Diff
Patch (27.91 KB, patch)
2013-02-18 04:42 PST, Vladislav Kaznacheev 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vladislav Kaznacheev 2013-02-13 08:02:21 PST 
Currently clicking on a color square in the Computed Style pane opens a Color Picker which does not add any useful functionality (changes are ignored and closing the picker causes a Javascript exception in the console).
Comment 1 Vladislav Kaznacheev 2013-02-13 08:38:57 PST 
Created attachment 188088 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-14 07:16:57 PST 
Comment on attachment 188088 [details]
Patch

Clearing flags on attachment: 188088

Committed r142876: <http://trac.webkit.org/changeset/142876>
Comment 3 WebKit Review Bot 2013-02-14 07:17:02 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2013-02-15 03:38:12 PST 
Re-opened since this is blocked by bug 109920
Comment 5 Vladislav Kaznacheev 2013-02-18 02:07:36 PST 
Created attachment 188828 [details]
Patch
Comment 6 Pavel Feldman 2013-02-18 04:31:45 PST 
Comment on attachment 188828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188828&action=review

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1572
> +     * @return {WebInspector.DOMNode}

{?WebInspector.DOMNode}

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1580
> +     * @return {WebInspector.StylesSidebarPane}

return ?WebInspector.StylesSidebarPane

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1940
> +

Too much whitespace
Comment 7 Vladislav Kaznacheev 2013-02-18 04:41:04 PST 
Comment on attachment 188828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=188828&action=review

>> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1572
>> +     * @return {WebInspector.DOMNode}
> 
> {?WebInspector.DOMNode}

Done

>> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1580
>> +     * @return {WebInspector.StylesSidebarPane}
> 
> return ?WebInspector.StylesSidebarPane

Done

>> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1940
>> +
> 
> Too much whitespace

Done
Comment 8 Vladislav Kaznacheev 2013-02-18 04:42:38 PST 
Created attachment 188850 [details]
Patch
Comment 9 WebKit Review Bot 2013-02-18 06:03:35 PST 
Comment on attachment 188850 [details]
Patch

Clearing flags on attachment: 188850

Committed r143207: <http://trac.webkit.org/changeset/143207>
Comment 10 WebKit Review Bot 2013-02-18 06:03:39 PST 
All reviewed patches have been landed.  Closing bug.