Bug 109683 - Column rules not affected by scroll offset
Summary: Column rules not affected by scroll offset
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Dave Hyatt
Depends on:
Reported: 2013-02-13 05:10 PST by Morten Stenshorne
Modified: 2014-04-25 14:06 PDT (History)
12 users (show)

See Also:

Testcase (881 bytes, text/html)
2013-02-13 05:10 PST, Morten Stenshorne
no flags Details
Corrected testcase (884 bytes, text/html)
2013-02-15 07:48 PST, Morten Stenshorne
no flags Details
Patch (5.31 KB, patch)
2013-02-27 01:19 PST, Morten Stenshorne
no flags Details | Formatted Diff | Diff
Patch (5.31 KB, patch)
2014-04-24 10:02 PDT, Morten Stenshorne
no flags Details | Formatted Diff | Diff
Patch (28.51 KB, patch)
2014-04-25 13:58 PDT, Dave Hyatt
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Morten Stenshorne 2013-02-13 05:10:13 PST
Created attachment 188060 [details]

If a multicol container has scrollable overflow, the column rules are not scrolled along with the content; instead they remain "fixed".
Comment 1 Morten Stenshorne 2013-02-15 07:48:03 PST
Created attachment 188570 [details]
Corrected testcase
Comment 2 Morten Stenshorne 2013-02-27 01:19:52 PST
Created attachment 190464 [details]
Comment 3 Brent Fulgham 2014-04-24 09:27:52 PDT
Comment on attachment 190464 [details]

I'm sorry we didn't review this sooner. It seems like a good change, but now needs to be adjusted a bit to apply cleanly (since a year has past!) Would you be willing to rebaseline the patch so we could push it through?
Comment 4 Morten Stenshorne 2014-04-24 10:01:45 PDT
Comment 5 Morten Stenshorne 2014-04-24 10:02:49 PDT
Created attachment 230090 [details]
Comment 6 Morten Stenshorne 2014-04-24 10:08:42 PDT
Ooh... Hyatt not CCed. Now he is. :)

Fixing the old multicol implementation at this point is rather unimportant, of course, but I thought at least the test would be nice to have.
Comment 7 Dave Hyatt 2014-04-25 13:29:26 PDT
This actually fails with the new multicolumn code now that I changed rule painting! Good catch! Let me make a patch for the new code (the old code doesn't matter).
Comment 8 Dave Hyatt 2014-04-25 13:47:38 PDT
Note column rules don't respect overflow:hidden clips in either old or new versions. We will need a bug on that too, and it's a bit harder to fix. :(
Comment 9 Dave Hyatt 2014-04-25 13:58:39 PDT
Created attachment 230196 [details]
Comment 10 Dave Hyatt 2014-04-25 14:06:29 PDT
Fixed in r167820.