Bug 109679 - [V8] Rename XXXAccessorGetter() to XXXAttrGetterCustom(), and XXXAccessorSetter() to XXXAttrSetterCustom()
Summary: [V8] Rename XXXAccessorGetter() to XXXAttrGetterCustom(), and XXXAccessorSett...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-13 04:03 PST by Kentaro Hara
Modified: 2013-02-14 03:20 PST (History)
5 users (show)

See Also:

Attachments
Patch (60.24 KB, patch)
2013-02-13 04:06 PST, Kentaro Hara 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-02-13 04:03:21 PST 
For naming consistency and clarification.
Comment 1 Kentaro Hara 2013-02-13 04:06:28 PST 
Created attachment 188049 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-13 04:21:08 PST 
Attachment 188049 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/bindings/scripts/CodeGeneratorV8.pm', u'Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp', u'Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp', u'Source/WebCore/bindings/scripts/test/V8/V8TestObj.h', u'Source/WebCore/bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8BiquadFilterNodeCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8ClipboardCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8CoordinatesCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8CustomEventCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8DeviceMotionEventCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8DeviceOrientationEventCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8DocumentLocationCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8EventCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8FileReaderCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8HTMLDocumentCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8HTMLElementCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8HTMLFrameElementCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8HTMLInputElementCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8HTMLLinkElementCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8HTMLMediaElementCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8HistoryCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8LocationCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8MessageEventCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8OscillatorNodeCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8PannerNodeCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8SVGLengthCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8WebKitAnimationCustom.cpp', u'Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp']" exit_code: 1
Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp:505:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp:510:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp:136:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/bindings/scripts/test/V8/V8TestInterface.cpp:145:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 4 in 35 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2013-02-13 11:59:10 PST 
Comment on attachment 188049 [details]
Patch

Rejecting attachment 188049 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=gce-cq-04', 'apply-attachment', '--no-update', '--non-interactive', 188049, '--port=chromium-xvfb']" exit_code: 2 cwd: /mnt/git/webkit-commit-queue

Last 500 characters of output:
e/bindings/v8/custom/V8PopStateEventCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8SVGLengthCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8WebKitAnimationCustom.cpp
patching file Source/WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', '--force', '--reviewer', 'Adam Barth']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/16543260
Comment 4 Kentaro Hara 2013-02-13 17:45:58 PST 
Comment on attachment 188049 [details]
Patch

Landed in r142834.
Comment 5 Kentaro Hara 2013-02-14 03:20:22 PST 
Committed r142864: <http://trac.webkit.org/changeset/142864>