Bug 109667 - [V8] There is no XXXConstructor that requires a custom getter
Summary: [V8] There is no XXXConstructor that requires a custom getter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-12 23:37 PST by Kentaro Hara
Modified: 2013-02-13 00:11 PST (History)
3 users (show)

See Also:


Attachments
Patch (2.15 KB, patch)
2013-02-12 23:38 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2013-02-12 23:37:02 PST
Currently '[Custom] attribute XXXConstructor xxx' generates XXXAttrGetter(). However, there is no XXXConstructor with [Custom]. In addition, it does make no sense to generate XXXAttrGetter() for such cases. We can remove the logic from CodeGeneratorV8.pm.
Comment 1 Kentaro Hara 2013-02-12 23:38:22 PST
Created attachment 188021 [details]
Patch
Comment 2 WebKit Review Bot 2013-02-13 00:11:41 PST
Comment on attachment 188021 [details]
Patch

Clearing flags on attachment: 188021

Committed r142727: <http://trac.webkit.org/changeset/142727>
Comment 3 WebKit Review Bot 2013-02-13 00:11:44 PST
All reviewed patches have been landed.  Closing bug.