To implement Threaded Coordinated Graphics, we need to implement CoordinatedSurface of WebKit1. Currently, Coordinated Graphics is using WebCoordinatedSurface as CoordinatedSurface, which resides in Source/WebKit2. WebCoordinatedSurface is implemented with some WebKit2 specific code, such as CoreIPC. So, we cannot reuse WebCoordinatedSurface in Threaded Coordinated Graphics. Therefore, WebKit1 CoordinatedSurface implementation with similar behavior is needed to implement Threaded Coordinated Graphics.
Created attachment 188009 [details] Patch
(In reply to comment #1) > Created an attachment (id=188009) [details] > Patch Sorry for the terrible naming. I couldn't come up with anything. Any suggestions on the naming? This patch is the general idea for how WebKit1 CoordinatedSurface would be implemented.
Comment on attachment 188009 [details] Patch Attachment 188009 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/16440635
Comment on attachment 188009 [details] Patch Attachment 188009 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/16439647
Comment on attachment 188009 [details] Patch Attachment 188009 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/16483600
Comment on attachment 188009 [details] Patch Attachment 188009 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/219001
Created attachment 203785 [details] Patch Rebased to upstream.
Comment on attachment 203785 [details] Patch Attachment 203785 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/701475
Comment on attachment 203785 [details] Patch Attachment 203785 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/763265
Comment on attachment 203785 [details] Patch Attachment 203785 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/662549
Comment on attachment 203785 [details] Patch Attachment 203785 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/769090
Created attachment 205848 [details] Patch
Comment on attachment 205848 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=205848&action=review > Source/WebCore/platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp:58 > + GraphicsContext* context = beginPaint(rect); > + client->paintToSurfaceContext(context); > + endPaint(); It would be better if this was all in one function. Otherwise it may look like beginPaint and endPaint can be called outside the context of paintToSurface. > Source/WebCore/platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp:77 > +#if USE(TEXTURE_MAPPER) I think we can remove these in coordinated-graphics code.
Created attachment 205863 [details] Patch
(In reply to comment #13) > (From update of attachment 205848 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=205848&action=review > > > Source/WebCore/platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp:58 > > + GraphicsContext* context = beginPaint(rect); > > + client->paintToSurfaceContext(context); > > + endPaint(); > > It would be better if this was all in one function. Otherwise it may look like beginPaint and endPaint can be called outside the context of paintToSurface. I agree. Removed beginPaint and endPaint. > > > Source/WebCore/platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp:77 > > +#if USE(TEXTURE_MAPPER) > > I think we can remove these in coordinated-graphics code. Fixed. Thanks for the review!
Comment on attachment 205863 [details] Patch Clearing flags on attachment: 205863 Committed r152307: <http://trac.webkit.org/changeset/152307>
All reviewed patches have been landed. Closing bug.