Bug 109653 - [Refactoring] Make SelectorChecker::mode a constructor parameter.
Summary: [Refactoring] Make SelectorChecker::mode a constructor parameter.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Takashi Sakamoto
URL:
Keywords:
Depends on:
Blocks: 89879
  Show dependency tree / graph
 
Reported: 2013-02-12 20:32 PST by Takashi Sakamoto
Modified: 2013-02-12 21:11 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.21 KB, patch)
2013-02-12 20:35 PST, Takashi Sakamoto 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Sakamoto 2013-02-12 20:32:01 PST 
Since StyleResolver uses SelectorChecker as an on-stack object now, no need to use setMode(Mode) to change SelectorChecker's mode.
Instead, we can make the mode a constructor parameter.
Comment 1 Takashi Sakamoto 2013-02-12 20:35:37 PST 
Created attachment 187997 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2013-02-12 20:42:34 PST 
Comment on attachment 187997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187997&action=review

> Source/WebCore/css/SelectorChecker.cpp:65
> +SelectorChecker::SelectorChecker(Document* document, Mode mode)

Does Mode declaration need to move to StyleResolver now?
Comment 3 WebKit Review Bot 2013-02-12 21:11:50 PST 
Comment on attachment 187997 [details]
Patch

Clearing flags on attachment: 187997

Committed r142717: <http://trac.webkit.org/changeset/142717>
Comment 4 WebKit Review Bot 2013-02-12 21:11:54 PST 
All reviewed patches have been landed.  Closing bug.