WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
109650
Use FocusEvent.relatedTarget in {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator.
https://bugs.webkit.org/show_bug.cgi?id=109650
Summary
Use FocusEvent.relatedTarget in {FocusIn,FocusOut,Focus,Blur}EventDispatchMed...
Hayato Ito
Reported
2013-02-12 19:38:34 PST
Remove m_{old,new}FocusedNode member variable from these mediators It's redundant since FocusEvent has relatedTarget member variable.
Attachments
Use FocusEvent.relatedTarget.
(13.09 KB, patch)
2013-02-12 20:24 PST
,
Hayato Ito
no flags
Details
Formatted Diff
Diff
Rabased
(13.07 KB, patch)
2013-02-12 21:02 PST
,
Hayato Ito
no flags
Details
Formatted Diff
Diff
Patch for landing
(13.10 KB, patch)
2013-02-12 21:41 PST
,
Hayato Ito
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Hayato Ito
Comment 1
2013-02-12 20:24:52 PST
Created
attachment 187996
[details]
Use FocusEvent.relatedTarget.
Hayato Ito
Comment 2
2013-02-12 20:25:37 PST
The uploaded patch depends on the patch in
bug 109561
.
Hayato Ito
Comment 3
2013-02-12 21:02:01 PST
Created
attachment 188000
[details]
Rabased
Dimitri Glazkov (Google)
Comment 4
2013-02-12 21:25:43 PST
Comment on
attachment 188000
[details]
Rabased View in context:
https://bugs.webkit.org/attachment.cgi?id=188000&action=review
> Source/WebCore/dom/FocusEvent.h:101 > + FocusInEventDispatchMediator(PassRefPtr<FocusEvent>);
explicit?
> Source/WebCore/dom/FocusEvent.h:110 > + FocusOutEventDispatchMediator(PassRefPtr<FocusEvent>);
explicit?
Hayato Ito
Comment 5
2013-02-12 21:32:39 PST
Thank you for the review. Let me land this after making these single parameter constructors explicit. (In reply to
comment #4
)
> (From update of
attachment 188000
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=188000&action=review
> > > Source/WebCore/dom/FocusEvent.h:101 > > + FocusInEventDispatchMediator(PassRefPtr<FocusEvent>); > > explicit? > > > Source/WebCore/dom/FocusEvent.h:110 > > + FocusOutEventDispatchMediator(PassRefPtr<FocusEvent>); > > explicit?
Hayato Ito
Comment 6
2013-02-12 21:41:47 PST
Created
attachment 188008
[details]
Patch for landing
WebKit Review Bot
Comment 7
2013-02-12 22:10:54 PST
Comment on
attachment 188008
[details]
Patch for landing Clearing flags on attachment: 188008 Committed
r142719
: <
http://trac.webkit.org/changeset/142719
>
WebKit Review Bot
Comment 8
2013-02-12 22:10:59 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug