Bug 109650 - Use FocusEvent.relatedTarget in {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator.
Summary: Use FocusEvent.relatedTarget in {FocusIn,FocusOut,Focus,Blur}EventDispatchMed...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
URL:
Keywords:
Depends on: 109561
Blocks: 109156
  Show dependency tree / graph
 
Reported: 2013-02-12 19:38 PST by Hayato Ito
Modified: 2013-02-12 22:10 PST (History)
3 users (show)

See Also:

Attachments
Use FocusEvent.relatedTarget. (13.09 KB, patch)
2013-02-12 20:24 PST, Hayato Ito 		no flags Details | Formatted Diff | Diff
Rabased (13.07 KB, patch)
2013-02-12 21:02 PST, Hayato Ito 		no flags Details | Formatted Diff | Diff
Patch for landing (13.10 KB, patch)
2013-02-12 21:41 PST, Hayato Ito 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2013-02-12 19:38:34 PST 
Remove m_{old,new}FocusedNode member variable from these mediators
It's redundant since FocusEvent has relatedTarget member variable.
Comment 1 Hayato Ito 2013-02-12 20:24:52 PST 
Created attachment 187996 [details]
Use FocusEvent.relatedTarget.
Comment 2 Hayato Ito 2013-02-12 20:25:37 PST 
The uploaded patch depends on the patch in bug 109561.
Comment 3 Hayato Ito 2013-02-12 21:02:01 PST 
Created attachment 188000 [details]
Rabased
Comment 4 Dimitri Glazkov (Google) 2013-02-12 21:25:43 PST 
Comment on attachment 188000 [details]
Rabased

View in context: https://bugs.webkit.org/attachment.cgi?id=188000&action=review

> Source/WebCore/dom/FocusEvent.h:101
> +    FocusInEventDispatchMediator(PassRefPtr<FocusEvent>);

explicit?

> Source/WebCore/dom/FocusEvent.h:110
> +    FocusOutEventDispatchMediator(PassRefPtr<FocusEvent>);

explicit?
Comment 5 Hayato Ito 2013-02-12 21:32:39 PST 
Thank you for the review. Let me land this after making these single parameter constructors explicit.

(In reply to comment #4)
> (From update of attachment 188000 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=188000&action=review
> 
> > Source/WebCore/dom/FocusEvent.h:101
> > +    FocusInEventDispatchMediator(PassRefPtr<FocusEvent>);
> 
> explicit?
> 
> > Source/WebCore/dom/FocusEvent.h:110
> > +    FocusOutEventDispatchMediator(PassRefPtr<FocusEvent>);
> 
> explicit?
Comment 6 Hayato Ito 2013-02-12 21:41:47 PST 
Created attachment 188008 [details]
Patch for landing
Comment 7 WebKit Review Bot 2013-02-12 22:10:54 PST 
Comment on attachment 188008 [details]
Patch for landing

Clearing flags on attachment: 188008

Committed r142719: <http://trac.webkit.org/changeset/142719>
Comment 8 WebKit Review Bot 2013-02-12 22:10:59 PST 
All reviewed patches have been landed.  Closing bug.