WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
109648
Clicking outside captions menu should dismiss it
https://bugs.webkit.org/show_bug.cgi?id=109648
Summary
Clicking outside captions menu should dismiss it
Dean Jackson
Reported
2013-02-12 18:47:27 PST
Clicking outside captions menu should dismiss it
Attachments
Patch
(11.26 KB, patch)
2013-02-12 18:51 PST
,
Dean Jackson
eric.carlson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dean Jackson
Comment 1
2013-02-12 18:51:37 PST
Created
attachment 187992
[details]
Patch
Eric Carlson
Comment 2
2013-02-12 21:36:11 PST
Comment on
attachment 187992
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=187992&action=review
> Source/WebCore/html/shadow/MediaControlsApple.cpp:283 > + if (event->type() == eventNames().clickEvent) { > + if (m_closedCaptionsContainer && m_closedCaptionsContainer->isShowing()) > + m_closedCaptionsContainer->hide();
You should stop the event propagation so it doesn't get any further, and eg. pause playback in a media document.
Dean Jackson
Comment 3
2013-02-13 12:37:47 PST
Committed
r142774
: <
http://trac.webkit.org/changeset/142774
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug