Bug 109648 - Clicking outside captions menu should dismiss it
Summary: Clicking outside captions menu should dismiss it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-12 18:47 PST by Dean Jackson
Modified: 2013-02-13 12:37 PST (History)
6 users (show)

See Also:


Attachments
Patch (11.26 KB, patch)
2013-02-12 18:51 PST, Dean Jackson
eric.carlson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-02-12 18:47:27 PST
Clicking outside captions menu should dismiss it
Comment 1 Dean Jackson 2013-02-12 18:51:37 PST
Created attachment 187992 [details]
Patch
Comment 2 Eric Carlson 2013-02-12 21:36:11 PST
Comment on attachment 187992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=187992&action=review

> Source/WebCore/html/shadow/MediaControlsApple.cpp:283
> +    if (event->type() == eventNames().clickEvent) {
> +        if (m_closedCaptionsContainer && m_closedCaptionsContainer->isShowing())
> +            m_closedCaptionsContainer->hide();

You should stop the event propagation so it doesn't get any further, and eg. pause playback in a media document.
Comment 3 Dean Jackson 2013-02-13 12:37:47 PST
Committed r142774: <http://trac.webkit.org/changeset/142774>